Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fsdocs does not generate correct code cell metadata for .ipynb #809

Closed
nhirschey opened this issue Mar 24, 2023 · 0 comments · Fixed by #812
Closed

fsdocs does not generate correct code cell metadata for .ipynb #809

nhirschey opened this issue Mar 24, 2023 · 0 comments · Fixed by #812
Assignees

Comments

@nhirschey
Copy link
Collaborator

nhirschey commented Mar 24, 2023

Dotnet interactive expects specific metadata in an F# notebook. This has evolved over time, and we need to update fsdocs ipynb output to match what they currently expect. See for example dotnet/interactive#2685

I reported the issue in the dotnet/interactive repo a few weeks ago, and they fixed it. But now it's broken again as of ths week's dotnet interactive. We should really make fsdocs output the metadata that dotnet interactive expects to help avoid breakages like this.

When the metadata is not correct, sometimes polyglot notebooks think an F# cell is C#. With correct metadata, this will not happen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant