FileSystemWatcher not working properly

[rojepp]

I was surprised to see changes to my sql file not being picked up:

  type Assessments  = SqlCommandProvider< "sql/Assessment.sql", cn>

So I looked in the code and found that the FileSystemWatcher would watch the source folder, with a filter of 'sql/Assessments.sql'. So I changed it to this and it worked:

  type Assessments  = SqlCommandProvider<"Assessment.sql", cn, ResolutionFolder = "sql">

Then, I couldn't load this .fs file from another folder, so I changed it to

  [<Literal>] 
  let AssessmentFile = __SOURCE_DIRECTORY__ + "/sql/Assessment.sql"
  type Assessments  = SqlCommandProvider<AssessmentFile, cn>

and it compiles, but stops picking upp changes because the FSW code seems to fail when file is rooted. And this final scenario works, even when doing #load from another folder:

  [<Literal>] 
  let sqlFolder = __SOURCE_DIRECTORY__ + "/sql/"
  type Assessments  = SqlCommandProvider<"Assessments.sql", cn, ResolutionFolder = sqlFolder>

Question: What is the purpose of ResolutionFolder? The TP will only ever read one file.

These are the changes I'd like to see:

• Unless path is rooted, use the file directory as root, so no need for __SOURCE_DIRECTORY__ to make it loadable from scripts in other folders.
• Make the FileSystemWatcher work with rooted paths as well as unrooted partial paths ('sql/file.sql').
• Remove ResolutionFolder. It no longer serves a purpose.
  These together would make the simplest first scenario Just Work™

[dmitry-a-morozov]

I'll have a look. It will take take some time because I'm swamped with my primary work.

[rojepp]

Would you accept a PR with the changes I've outlined?

[dmitry-a-morozov]

I don't use *.sql file much so it's hard for me to make this call.
Probably you're right.
Here is relevant discussion
#64
Let me check first if "ResolutionFolder" param is used in any of Tachyus prod projects.

[rojepp]

@dmitry-a-morozov I went ahead and implemented it. Feel free to ignore if you think its a bad idea. :)
This is a breaking change, but you wouldn't update to a newer version without recompiling, right? :)

[dmitry-a-morozov]

Cool,
Thanks for help.