Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Octokit to 13.0.1 #2808

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Update Octokit to 13.0.1 #2808

merged 1 commit into from
Aug 21, 2024

Conversation

Numpsy
Copy link
Contributor

@Numpsy Numpsy commented Aug 21, 2024

The last attempt at a release build failed with this error

Something failed, trying again: System.MissingMethodException: Method not found: 'Int32 Octokit.Release.get_Id()'.
   at [email protected](Release release)
   at Microsoft.FSharp.Control.AsyncPrimitives.CallThenInvokeNoHijackCheck[a,b](AsyncActivation`1 ctxt, b result1, FSharpFunc`2 userCode) in D:\a\_work\1\s\src\FSharp.Core\async.fs:line 528
   at Microsoft.FSharp.Control.Trampoline.Execute(FSharpFunc`2 firstAction) in D:\a\_work\1\s\src\FSharp.Core\async.fs:line 112

So I'm just wondering if the breaking Github API change at octokit/octokit.net#2941 has broken things and if taking the latest Octokit would fix it

@xperiandri xperiandri changed the title update Octokit to 13.0.1 Update Octokit to 13.0.1 Aug 21, 2024
@xperiandri xperiandri merged commit 06d5178 into fsprojects:master Aug 21, 2024
3 checks passed
@Numpsy Numpsy deleted the octo13 branch August 22, 2024 09:54
@Numpsy Numpsy mentioned this pull request Aug 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xperiandri xperiandri xperiandri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Numpsy @xperiandri