-
Notifications
You must be signed in to change notification settings - Fork 587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Mono.Posix.NETStandard with Mono.Unix #2781
base: master
Are you sure you want to change the base?
Conversation
The way that the macOS tests timing out causes the Linux tests to abort is ever so slightly not helpful :-( |
I have Mac M2. Do I just need to build and check if the build succeeds? |
Why does it try to find something from |
Some of the integration tests seem to be getting an exception thrown from FAKE/src/app/Fake.DotNet.Cli/DotNet.fs Line 839 in 3f98e8d
This change seems to avoid that error, though the CI run still fails. |
I tried another build with a longer timeout at https://github.com/Numpsy/FAKE/actions/runs/9537030314 and the Windows run passed, but macOS and Linux both timed out running the integration tests, not sure why that is.
Looks like some of the NuGet packages that it's installing have .NET 8 libs in them now and that causes warnings due to the old version of Paket in use, I don't know besides that. |
I had the same until I applied my fix above |
Hmm, looking at the CI logs for the mac build in more detail I see there's also this
from the |
I thought it runs on x64 on CI |
The macOS-Latest runners are now using M1 CPUs - one of the effects of #2773 is to put in back to the older runners on Intel CPUs |
Actually, the integration tests at
|
I expect that workaround that I mentioned has to work |
#2783 could help this one as well. |
When looking for info about problems with Mono.Posix.NetStandard on ARM macs, I found microsoft/sbom-tool#223 which suggests that they tried changing it to Mono.Unix to fix macOS ARM builds, but that broke it on Alpine Linux, so I'm not sure how good of an idea this would be if that's the case? |
Description
A test followup to #2780, in the hope that replacing the old Mono.Posix.NetStandard with the newer Mono.Unix will work better on ARM macs and help get the CI builds working again.
(I don't have an ARM mac to test with, so I'm guessing at some of this)