Release 5.14.0 #2318

matthid · 2019-05-11T14:00:36Z

BREAKING: Renamed NuGet.feedUrl to NuGet.galleryV1 and marked it as obsolete. Added galleryV2 and galleryV3 - Using NuGet.feedUrl fails #2323
ENHANCEMENT: Fake 5 now supports native libraries (like SQL and SQLite NuGet packages) - Native libraries are not resolved #2007
BUGFIX: DotNet.exec (dotnet installer) fails when username has a blank - DotNet.exec (dotnet installer) fails when username has a blank #2319
BUGFIX: Error when invoking fake run with different casings - Error when invoking fake run with different casings #2314
BUGFIX: Potential fix for incorrect console colors after running fake - Fake coloured text output leaves console colours changed on exit in some circumstances #2173
DOCS: Document difference between @@ and </> as well as Path.combineTrimEnd and Path.combine - Consider explaining the difference between path concatenation operators @@ and </> #2329

…ur suport) Fix a unit test failing locally

Fixes #2007

Fix a typo in IlMerge.fs

matthid · 2019-06-08T20:21:15Z

Currently test fails with:

Could not resolve native library 'SQLite.Interop.dll'.
No native libraries found!

This can happen for various reasons:
- The nuget cache (or packages folder) might be broken.
  -> Please save your state, open an issue and then
  - delete the source package of 'SQLite.Interop.dll' from the '~/.nuget' cache (and the 'packages' folder)
  - delete 'paket-files/paket.restore.cached' if it exists
  - delete '<script.fsx>.lock' if it exists
  - try running fake again
  - the package should be downloaded again

-> If the above doesn't apply or you need help please open an issue!

This is resolved with fsprojects/Paket#3593

…t ionide, see ionide/FsAutoComplete#402

matthid

some small details to fix

matthid · 2019-06-10T20:24:53Z

src/app/Fake.DotNet.Cli/DotNet.fs

@@ -441,7 +449,7 @@ module DotNet =
        let versionParamValue =
            match param.Version with
            | Latest -> "latest"
-            | Lkg -> "lkg"
+            | Lkg -> "coherent"


maybe we should add a new case instead of changing the existing one

Making a breaking change instead... (Just like the sdk guys did)

matthid · 2019-06-10T20:25:08Z

src/app/Fake.Core.Process/CmdLineParsing.fs

@@ -154,11 +154,31 @@ type Arguments =
            CmdLineParsing.toProcessStartInfo x.Args

 module Arguments =
+    let toWindowsCommandLine (a:Arguments) = a.ToWindowsCommandLine
+    let toLinuxShellCommandLine (a:Arguments) = a.ToLinuxShellCommandLine
+    let toStartInfo (a:Arguments) = a.ToStartInfo


we probably should add some comments here.

matthid · 2019-06-10T20:25:28Z

src/app/Fake.DotNet.Cli/DotNet.fs


+        Arguments.Empty


We probably should add some docs around this new feature.

matthid · 2019-06-10T20:25:43Z

src/app/Fake.DotNet.Cli/DotNet.fs

                if Environment.isUnix then
-                    let args = sprintf "%s %s" installScript (buildDotNetCliInstallArgs param)
+                    let args = installArgs |> Arguments.withPrefix [ installScript ]
+                    //let args = sprintf "%s %s" installScript (buildDotNetCliInstallArgs param)


comment can be removed

matthid · 2019-06-10T20:27:18Z

src/app/Fake.Runtime/FakeRuntime.fs

+    |> Seq.groupBy (function
+        | DependencyFile.Assembly ass -> ass.IsReferenceAssembly, System.Reflection.AssemblyName(ass.Info.FullName).Name
+        | DependencyFile.Library lib -> false, lib.File)
+    |> Seq.map (fun (_, group) -> group |> Seq.maxBy(function


space after maxBy

matthid and others added 8 commits May 11, 2019 15:59

next release

55d0ab6

next release

cecc721

Fix a typo in IlMerge.fs

93084ff

document @@ and </> fixes #2329

9789bb0

remove NuGet.feedUrl, fixes #2323

0c8eebe

If source is 'disabled' we no longer push to it (as myget has reset o…

ec380d4

…ur suport) Fix a unit test failing locally

Added support for native libraries

a13e0e6

Fixes #2007

Merge pull request #2326 from teo-tsirpanis/patch-1

9a4ceb4

Fix a typo in IlMerge.fs

matthid added 9 commits June 9, 2019 14:05

proper command line escaping, fixes #2319

3ef27d5

release notes

e1ff214

Merge branch 'release/next' of github.com:fsharp/FAKE into release/next

3be82ac

prepare code for assembly unloading and fix #2314

797ddae

make it silent

8a6036c

call Console.ResetColor() before exiting fake, fixes #2173

8363549

Add a couple of public APIs and small refactorings in order to suppor…

2418e69

…t ionide, see ionide/FsAutoComplete#402

ignore test for now

8016aad

paket update

182fe09

matthid commented Jun 10, 2019

View reviewed changes

matthid added 3 commits June 12, 2019 19:39

paket update

13835d3

enable test-case

62db0e9

5.14 release notes

a56f9d9

matthid changed the title ~~Next Release~~ Release 5.14.0 Jun 12, 2019

Some cleanup

6008dc2

matthid merged commit 2db6e13 into master Jun 12, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release 5.14.0 #2318

Release 5.14.0 #2318

matthid commented May 11, 2019 •

edited

Loading

matthid commented Jun 8, 2019

matthid left a comment

matthid Jun 10, 2019

matthid Jun 12, 2019

matthid Jun 10, 2019

matthid Jun 10, 2019

matthid Jun 10, 2019

matthid Jun 10, 2019

Release 5.14.0 #2318

Release 5.14.0 #2318

Conversation

matthid commented May 11, 2019 • edited Loading

matthid commented Jun 8, 2019

matthid left a comment

Choose a reason for hiding this comment

matthid Jun 10, 2019

Choose a reason for hiding this comment

matthid Jun 12, 2019

Choose a reason for hiding this comment

matthid Jun 10, 2019

Choose a reason for hiding this comment

matthid Jun 10, 2019

Choose a reason for hiding this comment

matthid Jun 10, 2019

Choose a reason for hiding this comment

matthid Jun 10, 2019

Choose a reason for hiding this comment

matthid commented May 11, 2019 •

edited

Loading