Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 5.3 #2022

Merged
merged 76 commits into from
Jul 30, 2018
Merged

Release 5.3 #2022

merged 76 commits into from
Jul 30, 2018

Conversation

matthid
Copy link
Member

@matthid matthid commented Jul 13, 2018

No description provided.

Maxime Mangel and others added 26 commits June 8, 2018 13:10
Add Fake.Rsync
402a885
Add AssemblyInfo.fs file for CI
bb12da9
Merge remote-tracking branch 'origin/master' into feature/rsync
d8b3972
@nt185071
Migration of WiX module to FAKE 5
4c56e14
@nt185071
Clarify some obsolete descriptions
04d80ef
@nt185071
Merge branch 'release/next' of https://github.com/fsharp/FAKE into re…
b40857b 
…lease/next-wixhelper
@cthangn
Merge branch 'release/next' into release/next-wixhelper
f119b09
@nt185071
Merge branch 'release/next-wixhelper' of https://github.com/cthangn/FAKE
f64fa3c 
 into release/next-wixhelper
@nt185071
Clean up sln file
3f819a6
@DanielFabian
Copy MSTest and add VSTest package.
fd78339
@DanielFabian
Port VSTest to FAKE 5.
575e15f
@DanielFabian
Incorporate code review feedback.
63439c6
@nt185071
remove obsolete types
bb40bc6 
mark some functions as internal
Update according to comments
6d7f564
@nt185071
Move Wix proj. to Fake.Installer
ea53080 
Mark more things internal (revert some)
@sliepie
Fix #2020 add slash instead of backslash on a non windows platform
dce8d15
@DanielFabian
Update the Obsolete error messages.
ad6ffdf
@DanielFabian
Add link to API docs.
6ca3485
@DanielFabian
Fix incorrect assembly name.
b15335e
@nt185071
more internals
f369ab6
@DanielFabian
Update API doc.
ca93ff5
@nt185071
fix wrong internal declaration in rec function
9bc9c5b
@cthangn
rename remaining Windows.Wix to Installer.Wix
059d447
Use Path.directorySeperatorChar
5259593
Fix: Path.directorySeparator instead of Path.directorySeparatorChar
3751c0d
@matthid
release notes
9e46a91
@matthid
Copy link
Member Author

matthid commented Jul 13, 2018

@kblohm It seems like something broke with the fake-template on AppVeyor as the builds in #2002 #2008 and #2021 went red :/ Could you please take a look? I hope this doesn't impact new users.

@kblohm
Copy link
Contributor

kblohm commented Jul 13, 2018

@matthid The template is working fine. The tests are broken. Probably since the update to the DotNet-Module that changed how the cli-version is resolved.
As far as i can tell this is what happens:
The tests use DotNet.exec to install the fake-template. That uses 2.1.300 because of the global.json. The tests then run in a temp-directory with (probably) 2.1.302 because that is the latest version. But the template is not installed for that version ;).

At least that is how i could reproduce it locally. Not sure why that only happens on AppVeyor. Maybe the latest version is not installed on everything else.

kblohm and others added 2 commits July 14, 2018 01:44
@kblohm
Fix template-tests on AppVeyor
3680ddb 
creates temporary test-folders inside of the repo in order to use
the global.json file and pin the dotnet version
@manne
Strg -> Ctrl
b5cf76e
vbfox and others added 28 commits July 22, 2018 23:20
@vbfox
Add FromEnvironVarOrDefault to BuildConfiguration
1173807
@sliepie
Add .NET Sdk 2.1.302 version
7e4cb4a
@matthid
Merge pull request #2034 from JarnoNijboer/dotnetsdk_2_1_302
e6b8e30 
Add .NET Sdk 2.1.302 version
@vbfox
Use a module for BuildConfiguration utility functions
7d46e21
@baronfel
add extended commit message
2fea22b
@matthid
docs
79761a4
@matthid
Merge branch 'release/next' of github.com:fsharp/FAKE into release/next
5dcfb06
@matthid
Merge pull request #2038 from baronfel/git-commit-extended-message
a3f35fa 
add extended commit message
@matthid
Properly resolve paket.dependencies, fixes #2025
024fbc4
@matthid
Merge branch 'release/next' of github.com:fsharp/FAKE into release/next
0b1ef09
@matthid
fixup
d819877
@matthid
fix build warning and make test do something.
ed44712
@matthid
fix outstanding issues from #1987 (comment)
eb72ac6
@matthid
release notes & build fix
6cca2de
@matthid
fix namespace.
f4f6ef3
@matthid
update fsf, fixes #2017
c130303
@matthid
Merge pull request #2030 from vbfox/glob_frombasedir
e113e64 
Suggestion: a way to start globbing from a specific basedir
@matthid
Merge pull request #2031 from vbfox/parse_buildconfiguration
40ace60 
Suggestion: Extend DotNet.BuildConfiguration
@matthid
release notes
a753e5e
@matthid
call with mono if required, fixes #2041
dc4329a
@matthid
update release notes
0b26e89
@matthid
paket update
b655885
@teo-tsirpanis
Add function to add additional command-line arguments in Fake.DotNet.…
9dc125d 
…DotNet.Options as a sequence of strings.This funcion internally converts them to a single string.It does not break anything.The downside is that the arguments cannot be _read_ as a sequence of strings.
@matthid
Update PULL_REQUEST_TEMPLATE.md
3e106a2
@matthid
Update RELEASE_NOTES.md
6044c9b
@matthid
Update RELEASE_NOTES.md
a8be7c4
@matthid
Merge pull request #2044 from teo-tsirpanis/with-additional-args
9b63d20 
Add function to add additional command-line arguments in Fake.DotNet.DotNet.Options as a sequence of strings.
@matthid
Update RELEASE_NOTES.md
6d7927c
@matthid matthid merged commit a050473 into master Jul 30, 2018
@matthid matthid changed the title Next Release Release 5.3 Aug 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@matthid @kblohm @nt185071 @cthangn @DanielFabian @sliepie @manne @vbfox @baronfel @teo-tsirpanis