Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Microsoft.NETFramework.ReferenceAssemblies instead of RoslynTools.ReferenceAssemblies. #2462

Closed
teo-tsirpanis opened this issue Jan 30, 2020 · 3 comments

Comments

@teo-tsirpanis
Copy link
Contributor

There is actually a NuGet package called Microsoft.NETFramework.ReferenceAssemblies. It depends on smaller packages depending on the framework, that contain the actual reference assemblies separately per framework. Each of these packages weighs about 10 MB.

This would be a real fix of #2238. The smaller packages would unburden a subpar internet connection, and FAKE would stop depending on a cryptic dependency from a custom source.

@matthid
Copy link
Member

matthid commented Jan 30, 2020

Yep indeed I just was too lazy to change it until now. It's really a non issue for me as 100mb is not that much and it is only downloaded once...
But PR is definitely appreciated

@teo-tsirpanis
Copy link
Contributor Author

Wait a minute, you had already fixed it in 33beb99. 😂

@matthid
Copy link
Member

matthid commented Jan 30, 2020

Ah didn't even look and apparently forgot about it :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants