Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

findPaketExecutable finds incorrect path on Windows when using Paket dotnet cli tool #2361

Closed
seanamosw opened this issue Jul 31, 2019 · 0 comments · Fixed by #2364
Closed

findPaketExecutable finds incorrect path on Windows when using Paket dotnet cli tool #2361

seanamosw opened this issue Jul 31, 2019 · 0 comments · Fixed by #2364

Comments

@seanamosw
Copy link
Contributor

Description

On Windows, if you have paket installed into your repo with dotnet tool install --tool-path ".paket", findPaketExecutable in Fake.DotNet.Paket/Paket.fs gets the incorrect paket path.

eg. C:\xxxx\.paket\.store\paket

Repro steps

  1. dotnet tool install --tool-path ".paket"
  2. Use Paket.restore/push/pack etc.

Expected behavior

The correct path of paket is found and used:
C:\xxxx\.paket\paket.exe

Cause

This seems to happen because the current logic in findPaketExecutable prioritises finding a file/folder with the name "paket".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix for #2361 seanamosw/FAKE
1 participant
@seanamosw