Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Method not found: Void BuildOptions #2168

Closed
haf opened this issue Oct 25, 2018 · 3 comments
Closed

Method not found: Void BuildOptions #2168

haf opened this issue Oct 25, 2018 · 3 comments
Labels
waiting for author Some information or action was requested and it needs to be addressed. Or a response from author

Comments

@haf
Copy link
Member

haf commented Oct 25, 2018

Description

Method not found: 'Void BuildOptions

When changing from storage: none to removing that line and doing a paket install thereafter.

Repro steps

Please provide the steps required to reproduce the problem

  1. ./build.fsx with code
// Define general properties across various commands (with arguments)
let inline withWorkDir wd =
  DotNet.Options.lift install.Value
  >> DotNet.Options.withWorkingDirectory wd
  >> DotNet.Options.withCustomParams (Some (sprintf "/p:Configuration=%s" buildMode))

// Set general properties without arguments
let inline dotnetSimple arg = DotNet.Options.lift install.Value arg

  1. Step B

Build it

Expected behavior

No crash

Actual behavior

Script reported an error:
-> BuildFailedException: Target 'BuildAPI' failed.
-> One or more errors occurred. (Method not found: 'Void BuildOptions..ctor(Options, BuildConfiguration, Microsoft.FSharp.Core.FSharpOption`1<System.String>, Microsoft.FSharp.Core.FSharpOption`1<System.String>, Microsoft.FSharp.Core.FSharpOption`1<System.String>, Microsoft.FSharp.Core.FSharpOption`1<System.String>, Boolean)'.)
-> MissingMethodException: Method not found: 'Void BuildOptions..ctor(Options, BuildConfiguration, Microsoft.FSharp.Core.FSharpOption`1<System.String>, Microsoft.FSharp.Core.FSharpOption`1<System.String>, Microsoft.FSharp.Core.FSharpOption`1<System.String>, Microsoft.FSharp.Core.FSharpOption`1<System.String>, Boolean)'.

Part of diff from paket install:

-    dotnet-fake (5.6.1) - clitool: true
-    Fake.Api.Github (5.6.1)
+    BlackFox.VsWhere (0.3.2)
+      FSharp.Core (>= 4.2.3)
+    dotnet-fake (5.9.3) - clitool: true
+    Fake.Api.Github (5.9.3)
       FSharp.Core (>= 4.3.4)
       Octokit (>= 0.32)
-    Fake.Core.CommandLineParsing (5.6.1)
+    Fake.Core.CommandLineParsing (5.9.3)
       FParsec (>= 1.0.3)
       FSharp.Core (>= 4.3.4)
-    Fake.Core.Context (5.6.1)
+    Fake.Core.Context (5.9.3)
       FSharp.Core (>= 4.3.4)
-    Fake.Core.Environment (5.6.1)
+    Fake.Core.Environment (5.9.3)
       FSharp.Core (>= 4.3.4)
-    Fake.Core.FakeVar (5.6.1)
-      Fake.Core.Context (>= 5.6.1)
+    Fake.Core.FakeVar (5.9.3)
+      Fake.Core.Context (>= 5.9.3)

Invariants broken

  • I haven't upgraded a major version, there should be no breaking changes
  • I haven't done paket update, there are should be no updated packages, going from storage: none to nothing about storage.

Workaround

Downgrade all of FAKE manually, despite it being the same MAJOR version.

Related information

  • Operating system: macOS
  • Branch
  • .NET Runtime, CoreCLR or Mono Version: 4.2.204, mono 5.14
  • Indications of severity: major
  • Version of FAKE (4.X, 5.X)
  • (if performance issue) Performance information, links to performance testing scripts
@haf haf changed the title Method not found: 'Void BuildOptions Method not found: Void BuildOptions Oct 25, 2018
@matthid
Copy link
Member

matthid commented Oct 25, 2018

@haf can you check if this is a duplicate of #2099?

@matthid
Copy link
Member

matthid commented Oct 29, 2018

@haf have you checked? It could also be another dependency depending on one of the fake modules depending on a API which we do (historically) not consider to be binary compatible.
Or we simply introduced a breaking change somewhere

@matthid matthid added the waiting for author Some information or action was requested and it needs to be addressed. Or a response from author label Oct 29, 2018
@haf
Copy link
Member Author

haf commented Oct 29, 2018

@matthid I have not and I'm afraid I don't have it readily available to check any more. I'm closing this due to the lack to repro.

@haf haf closed this as completed Oct 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting for author Some information or action was requested and it needs to be addressed. Or a response from author
Projects
None yet
Development

No branches or pull requests

2 participants