Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FAKE5 Getting Started Guide is outdated #1854

Closed
mclang opened this issue Apr 9, 2018 · 4 comments
Closed

FAKE5 Getting Started Guide is outdated #1854

mclang opened this issue Apr 9, 2018 · 4 comments

Comments

@mclang
Copy link

mclang commented Apr 9, 2018

I noticed some things in FAFE - Getting started guide are outdated, at least when using FAKE v5.0.0-rc001

This doesn't work:

Target.create "BuildApp" (fun _ ->
  !! "src/app/**/*.csproj"
    |> MSBuild.runRelease buildDir "Build"
    |> Trace.Log "AppBuild-Output: "
)

Later it is written differently, but also this doesn't work:

Target.create "BuildApp" (fun _ ->
   !! "src/app/**/*.csproj"
     |> MSBuild.runRelease buildDir "Build"
     |> Trace.logItems "AppBuild-Output: "
)

It seems that what previously was MsBuild.MsBuildRelease and Trace.Log is now MSBuild.runRelease and Trace.logItems, and that now you need to define setParams function for the runRelease and runDebug functions.

I haven't found out yet how to get things running, so can't do PR of the needed changes myself

@matthid
Copy link
Member

matthid commented Apr 9, 2018

Thanks for reporting! And yes the replacements you suggest are the correct ones afaics. setParams probably will be id.

I haven't found out yet how to get things running, so can't do PR of the needed changes myself

Not sure if you mean "I don't know how the working script should look like" or "I don't know how to get documentation running locally.

Just in case it is the second: You don't need anything working in order to improve docs. For example you can use the github web:
image

@mclang
Copy link
Author

mclang commented Apr 9, 2018

To clarify my sentence:
I know how to make PR for the documentation, but I don't know how to make the required setParams function, because I haven't yet found documentation how to create one.

Why do you need one anyways when previously you could get started simple?

@matthid
Copy link
Member

matthid commented Apr 9, 2018

Why do you need one anyways when previously you could get started simple?

Problem was that previously there was no way to set msbuild parameters when using "globbing" now there is.

because I haven't yet found documentation how to create one.

Just using id as argument should work and give the defaults?
There is some documentation here: https://fake.build/apidocs/fake-dotnet-msbuild.html

@matthid matthid closed this as completed in eca91a5 Apr 9, 2018
@mclang
Copy link
Author

mclang commented Apr 10, 2018

Thanks, getting forward now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants