Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What is 5.0 replacement for legacy Fake.FSIHelper.fsiPath? #1841

Closed
jackfoxy opened this issue Mar 31, 2018 · 10 comments
Closed

What is 5.0 replacement for legacy Fake.FSIHelper.fsiPath? #1841

jackfoxy opened this issue Mar 31, 2018 · 10 comments

Comments

@jackfoxy
Copy link
Contributor

Description

What is 5.0 replacement for legacy Fake.FSIHelper.fsiPath?

Actual behavior

No migration help message available.

Related information

5.0.0-beta025 +

@matthid
Copy link
Member

matthid commented Apr 8, 2018

I don't think we have one, as we don't have a FSI module on FAKE 5 yet.

@jackfoxy
Copy link
Contributor Author

jackfoxy commented Apr 8, 2018

Would that be related to the item

Use F# Type Providers and F# Interactive in .NET Core 2.1. (specifically FSI)

on the MSFT VS roadmap https://docs.microsoft.com/en-us/visualstudio/productinfo/vs2018-roadmap ?

I imagine this is also the major impediment to moving forward with FSharp.Formatting 3.0?

@matthid
Copy link
Member

matthid commented Apr 8, 2018

Maybe a bit, but yeah we probably should upgrade netcore to 2.1

@vanceism7
Copy link
Contributor

Hey @matthid, is this issue do-able? If so, I can port over the fsihelper module. What would the module be called? Fake.FSI.Helper? Or just Fake.FSIHelper?

@matthid
Copy link
Member

matthid commented May 2, 2018

@vanceism7 yes I think it can be added. I guess we would name it Fake.DotNet.Fsi or Fake.Tools.Fsi

@matthid
Copy link
Member

matthid commented May 22, 2018

PR is welcome. I'm closing this to clean the house a bit ;)

@matthid matthid closed this as completed May 22, 2018
@vanceism7
Copy link
Contributor

Just a bump for whoever is wondering, I should have a PR coming in for this pretty soon

@halcwb
Copy link

halcwb commented Jun 23, 2019

This has been a year, will there be a FAKE 5 FSIhelper module, or is this still open?

@vanceism7
Copy link
Contributor

@halcwb: looks like a PR for this was merged about a year ago.

#1970

It wasn't merged into a main branch but I assume all the changes have been integrated into the main release by now

@matthid
Copy link
Member

matthid commented Jun 23, 2019

Yes it is here since 5.1.0, should have liked those issues up :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants