Projects out of process (new api) #470
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| type file | ||
| id FSharp.Compiler.Service.ProjectCracker | ||
| description | ||
| Adds cracking capabilities. | ||
| authors | ||
| Microsoft Corporation, Robin Neatherway | ||
| summary | ||
| Cracking projects | ||
| licenseurl https://github.com/fsharp/FSharp.Compiler.Service/blob/master/LICENSE | ||
| projecturl https://github.com/fsharp/FSharp.Compiler.Service | ||
| iconurl https://raw.github.com/fsharp/FSharp.Compiler.Service/master/misc/logo.png | ||
| tags | ||
| F#, fsharp, msbuild, editor | ||
| files | ||
| ../bin/v4.5/FSharp.Compiler.Service.ProjectCrackerSub.exe ==> lib/net45 | ||
| ../bin/v4.5/FSharp.Compiler.Service.ProjectCrackerSub.?db ==> lib/net45 | ||
| ../bin/v4.5/FSharp.Compiler.Service.ProjectCrackerSub.dll.?db ==> lib/net45 | ||
| ../bin/v4.5/FSharp.Compiler.Service.ProjectCracker.dll ==> lib/net45 | ||
| ../bin/v4.5/FSharp.Compiler.Service.ProjectCracker.XML ==> lib/net45 | ||
| ../bin/v4.5/FSharp.Compiler.Service.ProjectCracker.?db ==> lib/net45 | ||
| ../bin/v4.5/FSharp.Compiler.Service.ProjectCracker.dll.?db ==> lib/net45 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| <?xml version="1.0" encoding="utf-8" ?> | ||
| <configuration> | ||
| <startup> | ||
| <supportedRuntime version="v4.0" sku=".NETFramework,Version=v4.5" /> | ||
| </startup> | ||
| <runtime> | ||
| <assemblyBinding xmlns="urn:schemas-microsoft-com:asm.v1"> | ||
| <dependentAssembly> | ||
| <assemblyIdentity name="Microsoft.Build.Framework" publicKeyToken="b03f5f7f11d50a3a" culture="neutral" /> | ||
| <bindingRedirect oldVersion="0.0.0.0-12.0.0.0" newVersion="12.0.0.0" /> | ||
| </dependentAssembly> | ||
| <dependentAssembly> | ||
| <assemblyIdentity name="Microsoft.Build.Engine" publicKeyToken="b03f5f7f11d50a3a" culture="neutral" /> | ||
| <bindingRedirect oldVersion="0.0.0.0-12.0.0.0" newVersion="12.0.0.0" /> | ||
| </dependentAssembly> | ||
| </assemblyBinding> | ||
| </runtime> | ||
| </configuration> | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,106 @@ | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <Project ToolsVersion="12.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> | ||
| <Import Project="$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props" Condition="Exists('$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props')" /> | ||
| <PropertyGroup> | ||
| <Configuration Condition=" '$(Configuration)' == '' ">Debug</Configuration> | ||
| <Platform Condition=" '$(Platform)' == '' ">AnyCPU</Platform> | ||
| <SchemaVersion>2.0</SchemaVersion> | ||
| <ProjectGuid>b1bdd96d-47e1-4e65-8107-fbae23a06db4</ProjectGuid> | ||
| <OutputType>Exe</OutputType> | ||
| <RootNamespace>FSharp.Compiler.Service.ProjectCracker.Exe</RootNamespace> | ||
| <AssemblyName>FSharp.Compiler.Service.ProjectCracker.Exe</AssemblyName> | ||
| <TargetFrameworkVersion Condition=" '$(TargetFrameworkVersion)' == '' ">v4.5</TargetFrameworkVersion> | ||
| <TargetFSharpCoreVersion>4.3.0.0</TargetFSharpCoreVersion> | ||
| <SolutionDir Condition="$(SolutionDir) == '' Or $(SolutionDir) == '*Undefined*'">..\..\..\</SolutionDir> | ||
| <Name>FSharp.Compiler.Service.ProjectCracker.Exe</Name> | ||
| <OtherFlags>$(OtherFlags) --staticlink:FSharp.Core</OtherFlags> | ||
| <NoWarn>$(NoWarn);40</NoWarn> | ||
| <AutoGenerateBindingRedirects>true</AutoGenerateBindingRedirects> | ||
| <Name>FSharp.Compiler.Service.ProjectCracker.Exe</Name> | ||
| </PropertyGroup> | ||
| <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Debug|AnyCPU' "> | ||
| <DebugSymbols>true</DebugSymbols> | ||
| <DebugType>full</DebugType> | ||
| <Optimize>false</Optimize> | ||
| <Tailcalls>false</Tailcalls> | ||
| <OutputPath>bin\Debug\</OutputPath> | ||
| <DefineConstants>DEBUG;TRACE</DefineConstants> | ||
| <WarningLevel>3</WarningLevel> | ||
| <PlatformTarget>AnyCPU</PlatformTarget> | ||
| <DocumentationFile>bin\Debug\FSharp.Compiler.Service.ProjectCracker.Exe.XML</DocumentationFile> | ||
| <Prefer32Bit>true</Prefer32Bit> | ||
| </PropertyGroup> | ||
| <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|AnyCPU' "> | ||
| <DebugType>pdbonly</DebugType> | ||
| <Optimize>true</Optimize> | ||
| <Tailcalls>true</Tailcalls> | ||
| <OutputPath>bin\Release\</OutputPath> | ||
| <DefineConstants>TRACE</DefineConstants> | ||
| <WarningLevel>3</WarningLevel> | ||
| <PlatformTarget>AnyCPU</PlatformTarget> | ||
| <DocumentationFile>bin\Release\FSharp.Compiler.Service.ProjectCracker.Exe.XML</DocumentationFile> | ||
| <Prefer32Bit>true</Prefer32Bit> | ||
| </PropertyGroup> | ||
| <PropertyGroup> | ||
| <MinimumVisualStudioVersion Condition="'$(MinimumVisualStudioVersion)' == ''">11</MinimumVisualStudioVersion> | ||
| </PropertyGroup> | ||
| <Choose> | ||
| <When Condition="'$(VisualStudioVersion)' == '11.0'"> | ||
| <PropertyGroup Condition="Exists('$(MSBuildExtensionsPath32)\..\Microsoft SDKs\F#\3.0\Framework\v4.0\Microsoft.FSharp.Targets')"> | ||
| <FSharpTargetsPath>$(MSBuildExtensionsPath32)\..\Microsoft SDKs\F#\3.0\Framework\v4.0\Microsoft.FSharp.Targets</FSharpTargetsPath> | ||
| </PropertyGroup> | ||
| </When> | ||
| <Otherwise> | ||
| <PropertyGroup Condition="Exists('$(MSBuildExtensionsPath32)\Microsoft\VisualStudio\v$(VisualStudioVersion)\FSharp\Microsoft.FSharp.Targets')"> | ||
| <FSharpTargetsPath>$(MSBuildExtensionsPath32)\Microsoft\VisualStudio\v$(VisualStudioVersion)\FSharp\Microsoft.FSharp.Targets</FSharpTargetsPath> | ||
| </PropertyGroup> | ||
| </Otherwise> | ||
| </Choose> | ||
| <Import Project="$(FSharpTargetsPath)" /> | ||
| <ItemGroup> | ||
| <Compile Include="ProjectCrackerOptions.fs" /> | ||
| <Compile Include="Program.fs" /> | ||
| <None Include="App.config" /> | ||
| </ItemGroup> | ||
| <ItemGroup> | ||
| <Reference Include="Microsoft.Build.Framework" Condition=" '$(TargetFrameworkVersion)' == 'v4.0'" /> | ||
| <Reference Include="Microsoft.Build.Engine" Condition=" '$(TargetFrameworkVersion)' == 'v4.0'" /> | ||
| <Reference Include="Microsoft.Build" Condition=" '$(TargetFrameworkVersion)' == 'v4.0'" /> | ||
| <Reference Include="Microsoft.Build.Utilities.v4.0" Condition=" '$(TargetFrameworkVersion)' == 'v4.0'" /> | ||
|
There was a problem hiding this comment. I assume these don't need private=true, because if you use the .NET 4.0 version then you are assuming MSBuild is installed with .NET? There was a problem hiding this comment. That's right, yes. Although I am tempted not to provide a .NET 4.0 version and require MSBuild 12 or 14 be installed separately. |
||
| <Reference Include="Microsoft.Build.Framework, Version=12.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a" Condition=" '$(TargetFrameworkVersion)' == 'v4.5'"> | ||
| <SpecificVersion>True</SpecificVersion> | ||
| </Reference> | ||
| <Reference Include="Microsoft.Build.Engine, Version=12.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a" Condition=" '$(TargetFrameworkVersion)' == 'v4.5'"> | ||
| <SpecificVersion>True</SpecificVersion> | ||
| </Reference> | ||
| <Reference Include="Microsoft.Build, Version=12.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a" Condition=" '$(TargetFrameworkVersion)' == 'v4.5'"> | ||
| <SpecificVersion>True</SpecificVersion> | ||
| </Reference> | ||
| <Reference Include="Microsoft.Build.Utilities.v12.0" Condition=" '$(TargetFrameworkVersion)' == 'v4.5'" /> | ||
| <Reference Include="mscorlib" /> | ||
| <Reference Include="FSharp.Core, Version=$(TargetFSharpCoreVersion), Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a"> | ||
| <Private>False</Private> | ||
| </Reference> | ||
| <Reference Include="Microsoft.Build" /> | ||
| <Reference Include="Microsoft.Build.Engine" /> | ||
| <Reference Include="Microsoft.Build.Framework" /> | ||
| <Reference Include="Microsoft.Build.Utilities.v4.0" /> | ||
| <Reference Include="mscorlib" /> | ||
| <Reference Include="FSharp.Core, Version=$(TargetFSharpCoreVersion), Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a"> | ||
| <Private>True</Private> | ||
|
There was a problem hiding this comment. You have two FSHarp.Core references, one with Private true and one with Private false. I assume that is problematic? There was a problem hiding this comment. AHA! Thanks so much for looking, that at least fixed the tests locally on Linux. I was scouring the project files looking for things like last time, but missed this somehow. Removing the Private true version was needed. |
||
| </Reference> | ||
| <Reference Include="System" /> | ||
| <Reference Include="System.Core" /> | ||
| <Reference Include="System.Numerics" /> | ||
| <Reference Include="System.Runtime.Serialization" /> | ||
| <Reference Include="System.Xml" /> | ||
| <Reference Include="System.Xml" /> | ||
| </ItemGroup> | ||
| <!-- To modify your build process, add your task inside one of the targets below and uncomment it. | ||
| Other similar extension points exist, see Microsoft.Common.targets. | ||
| <Target Name="BeforeBuild"> | ||
| </Target> | ||
| <Target Name="AfterBuild"> | ||
| </Target> | ||
| --> | ||
| </Project> | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should there be a binding redirect for FSharp.Core in here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, no. I see. You statically link it.