Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Add Compile* methods from SimpleSourceCodeServices to SourceCodeServices to unify API #516

Closed
7sharp9 opened this issue Jan 20, 2016 · 1 comment

Comments

@7sharp9
Copy link
Member

7sharp9 commented Jan 20, 2016

#362 Discusses this

Essentially Compile and CompileToDynamicAssembly methods should be brought over from SimpleSourceCodeService to SourceCodeServices.

@dsyme In #362 you mention arguments should be textual to conform with the rest of the API, which methods were you referring to?

Also to provision a PR to add this feature would you be happy with adding the compile helpers to a module within Services.fs so that SimpleSourceCodeServices and SourceCodeServices share the common implementation?

@dsyme
Copy link
Contributor

dsyme commented Oct 13, 2016

Closing as we don't need to track this with an issue. We just need to do it :)

@dsyme dsyme closed this as completed Oct 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants