handle content when it's an empty string #1100
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
🤖 Generated by Copilot at 19c74a2
Fix text document change handling for whole first line replacements in
FsAutoComplete.Lsp.fs
. Use named text instead of text edit to avoid line ending and offset issues.🤖 Generated by Copilot at 19c74a2
📝🐛🚀
WHY
FSAC currently crashes when the buffer is empty and we type something. I thought I saw the same behaviour on the F# Data Adaptive version, but I was wrong. Since the latter doesn't suffer from this edge case so no need for code change there.
Fixes #1091
HOW
🤖 Generated by Copilot at 19c74a2
FsAutoComplete.Lsp.fs
file, which implements the F# language server protocol.