-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include module information on TestAdapterEntry #1071
Include module information on TestAdapterEntry #1071
Conversation
This approach looks great - I've started the tests and I'm happy to merge once green. Would you be willing to continue updating the test explorer in Ionide to match once this is released? |
Before I merge, if you wanted to get a PR prepped on the Ionide side you could build this branch, get the path to the newly-created fsautocomplete.dll, and then set that value as the |
The failing I'll take a look at creating a Ionide PR. Turns out it's more complicated than I thought, since the part of the code that tries to construct the full name has no access to the |
Turns out I missed a case: module OtherSpace
module Outer2 =
[<TestFixture>]
type InnerClass() =
[<Test>]
member this.Test1 () =
Assert.Pass() Leads to |
Great work @kojo12228! |
yes, very well done 🎆 |
Thanks @baronfel! And thanks @nojaf, our chat was very helpful, I decided to plough through the change that night. https://fsprojects.github.io/fantomas/reference/index.html was very useful, thought search was a bit difficult with the really long DU cases! |
Add a new field
TestAdapterEntry.ModuleType
, to show whether the given entry is a module, and separately a module with a suffix (in IL). The allows for handling the following two cases which previously couldn't be handled by the existing record:TestNameSpace.Outer+Inner+Innermost.Test2
TestNameSpace.Outer.Inner.Innermost.Test2
TestNameSpace.SharedNameModule.Test1
TestNameSpace.SharedName
See ionide/ionide-vscode-fsharp#1756 for more context.