-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add info tooltip to inlay hints #972
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just need to patch up assertions on the tooltips in the tests. I guess they're all the same unless we're testing the permutations of the enable/disable mechanism.
Two issues: The message overrides the original tooltip (which currently only happens when hint gets truncated): I think when InlayHint provides a Tooltip we should put a separator between Inlay Hint tooltip and info on how to hide inlay hints (like the separator between current tooltip & "double click to insert") The message is very VsCode/Ionide centric:
I think we should move the info to the client side: |
This is a fair point - I've changed the default value for |
No description provided.