Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Ionide.LanguageServerProtocol nuget #875

Merged
merged 2 commits into from
Jan 16, 2022

Conversation

razzmatazz
Copy link
Contributor

No description provided.

@baronfel
Copy link
Contributor

baronfel commented Jan 4, 2022

Thanks for this! I'm pretty happy to remove the local copy in favor of the nuget, and the majority of this looks good, but I want to take some time to dig into the slightly different API shapes (which I imagine are just a result of spec updates to the LSP library. Tests are passing mostly though, so that bodes well!

@razzmatazz
Copy link
Contributor Author

razzmatazz commented Jan 4, 2022

No prob :) I am not testing FSAC myself a lot--this mostly a port from my C# server work, so this definitely warrants some testing.

@baronfel
Copy link
Contributor

baronfel commented Jan 8, 2022

Found a blocker (ionide/LanguageServerProtocol#11), but functionally it's working well!

@razzmatazz
Copy link
Contributor Author

great!

@baronfel
Copy link
Contributor

baronfel commented Jan 9, 2022

Once 0.3.1 of the LSP nuget is published, we can update that here and merge this work. I don't want to take this without in-line xmldoc tooltips, because of how much information about the spec is embedded in them. Thanks for doing this work!

@baronfel
Copy link
Contributor

0.3.1 was pushed, will update this branch and merge today, before workign on the broader release changes I want to make.

@baronfel baronfel merged commit 6f74c84 into ionide:main Jan 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants