Fix probing for the dotnet binary #854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
note that 13 tests are failing due to fallout from the .net 6 work - these are mostly tests around |
baronfel
force-pushed
the
fix-dotnet-probing
branch
2 times, most recently
from
6a6ed77 to
c6523ce
Compare
baronfel
force-pushed
the
fix-dotnet-probing
branch
2 times, most recently
from
21e8588 to
d516112
Compare
Krzysztof-Cieslak
approved these changes
Nov 17, 2021
baronfel
force-pushed
the
fix-dotnet-probing
branch
from
d516112 to
12ec99f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #853 by updating to ProjInfo 0.55.1, which contains the necessary fix. This came with a slight API surface area change, and we fail-fast in the background services if we can't find the binary now. The same fast failure will happen in the main startup of the app if
dotnetcan't be found, so it's generally safe to assume that if the parent FSAC process could find it, the spawned background services will as well.This was tested by building the tool locally, installing it using
dotnet tool install --add-source <output dir> fsautocomplete, then runningdotnet fsautocomplete, attaching a debugger, and verifying the in state of the program that the correct path todotnetwas found.