(mostly) implement explicit type annotation codefix #807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baronfel
changed the title
baronfel
commented
Jun 25, 2021
| @@ -331,6 +331,57 @@ type FSharpParseFileResults with | |||
| None | |||
| | _ -> defaultTraverse expr }) | |||
| ) | |||
|
|
|||
| member scope.IsTypeAnnotationGivenAtPositionPatched pos = | |||
There was a problem hiding this comment.
ported over from upstream
| @@ -21,7 +21,7 @@ type SourceTextExtensions = | |||
| static member GetText(t: ISourceText, m: FSharp.Compiler.Text.Range): Result<string, string> = | |||
| let allFileRange = Range.mkRange m.FileName Pos.pos0 (t.GetLastFilePosition()) | |||
| if not (Range.rangeContainsRange allFileRange m) | |||
| then Error "%A{m} is outside of the bounds of the file" | |||
| then Error $"%A{m} is outside of the bounds of the file" | |||
There was a problem hiding this comment.
fix for malformed format string
| @@ -397,6 +397,15 @@ module Array = | |||
| | _ when n >= xs.Length || n < 0 -> xs, [||] | |||
| | _ -> xs.[0..n-1], xs.[n..] | |||
|
|
|||
| let partitionResults (xs: _ []) = | |||
There was a problem hiding this comment.
used in refactor of codefixes
| @@ -25,6 +25,7 @@ module Types = | |||
| type GetParseResultsForFile = string<LocalPath> -> FSharp.Compiler.Text.Pos -> Async<ResultOrString<ParseAndCheckResults * string * FSharp.Compiler.Text.ISourceText>> | |||
| type GetProjectOptionsForFile = string<LocalPath> -> ResultOrString<FSharp.Compiler.SourceCodeServices.FSharpProjectOptions> | |||
|
|
|||
| [<RequireQualifiedAccess>] | |||
There was a problem hiding this comment.
generally moving to RQA on DUs to prevent conflicts
| @@ -37,7 +38,7 @@ module Types = | |||
| SourceDiagnostic: Diagnostic option | |||
| Kind: FixKind } | |||
|
|
|||
| type CodeFix = CodeActionParams -> Async<Fix list> | |||
| type CodeFix = CodeActionParams -> Async<Result<Fix list, string>> | |||
There was a problem hiding this comment.
making this AsyncResult makes authoring codefixes nicer, IMO. we do the unification and logging in the LSP endpoint itself now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #806
Ports over most of the implementation from upstream, but currently doesn't handle function-typed parameters at all due to missing fields on the FCS data types.