Reenable FSharpLint in the product #799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baronfel
commented
Jun 18, 2021
| Configuration = lintConfig | ||
| CancellationToken = Some ctok } | ||
| { Ast = ast | ||
| Source = sourceCode.ToString() |
There was a problem hiding this comment.
it might be nice to see if FSharpLint can move to an ISourceText-based interface to reduce the amount of memory required (as this will allocate a new string).
|
This is good to merge: the failures are in the (known flaky) rename test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With FSharpLint updated to FCS 39, we can now reenable it here, along with the tests.
Should close ionide/ionide-vscode-fsharp#1533 when Ionide is updated.