Fix PublishDiagnosticsCapabilities type
#574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per the 3.15 spec, this should be a nested type, not a bool option. Closes ionide#567
|
Thanks for this! The changes look fine to me, I'm just wondering why the CI builds haven't kicked off. |
|
@baronfel I haven't a clue :| Azure Pipelines isn't a tool I've used. Are y'all willing to sort that on your end, or should I try to dig in on mine? |
|
Hi, is there any blocker for this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the 3.15 spec, this should be a nested type, not a bool option.
...that said, while this builds and runs nicely on my machine, I haven't worked with this code base before, and I'm not at all sure I've gotten this right, particularly style-wise.
Thanks for the awesome project, and in advance for the review!
Closes #567