Enable seamless support for Reference Assemblies #1228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheAngryByrd
approved these changes
Feb 6, 2024
|
Initial tests on my big work project look good. |
|
Same on my tests - projects that are referenced and have ref assemblies are successfully being passed as compiler options. |
|
Going to merge this and work on a new release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the way FSharpProjectOptions are calculated so that they correctly identify and use TargetRefPath instead of TargetPath for the output of a referenced project when applicable. This should have very little impact on the overall behavior of the LSP, but it should enable somewhat of a performance boost due to theoretically the ref assemblies not changing quite as much.