Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
🤖 Generated by Copilot at 15b8219
This pull request changes various string comparison operations in the
FsAutoComplete
project to useStringComparison.Ordinal
instead of the default culture-sensitive option. This improves the performance, consistency, and correctness of the code, as it avoids unnecessary allocations and potential bugs related to different cultures. The changes affect several modules and files, such asCodeGeneration.fs
,Commands.fs
,CompilerServiceInterface.fs
,DocumentationFormatter.fs
,InlayHints.fs
,Lexer.fs
,SignatureFormatter.fs
,TestAdapter.fs
,TipFormatter.fs
,TypedAstUtils.fs
,Utils.fs
, and some code fixes.🤖 Generated by Copilot at 15b8219
🚀🛠️📝
WHY
Using Ordinal is both faster and more correct as our intent is to do symbolic compares.
See https://learn.microsoft.com/en-us/dotnet/standard/base-types/best-practices-strings for the full story.
HOW
🤖 Generated by Copilot at 15b8219
StringComparison.Ordinal
forStartsWith
,EndsWith
, andIndexOf
methods to avoid culture-sensitive comparisons and improve performance (link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link)open System
directive toLexer
andTestAdapter
modules to makeStringComparison
enum available (link, link)open System
directive toRemoveRedundantAttributeSuffix
module to makeStringComparison
enum available (link)