Ignore requests that would cause circular dependencies #1173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nojaf
pushed a commit
to nojaf/FsAutoComplete
that referenced
this pull request
Nov 3, 2023
* Ignore requests that would cause circular dependencies * format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
🤖 Generated by Copilot at e4efa4e
This pull request adds a feature to support adding project references via code actions in the LSP server. It also prevents adding a project reference to itself and simplifies some pattern matching logic in
AdaptiveFSharpLspServer.fsandFsAutoComplete.Lsp.fs.🤖 Generated by Copilot at e4efa4e
🛠️🔄🧹
WHY
Help people who chose the target project by accident.
HOW
🤖 Generated by Copilot at e4efa4e
CoreResponseby ignoring unused message (link)