Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for dot in sprintf format. #1146

Merged
merged 1 commit into from
Jul 16, 2023

Conversation

nojaf
Copy link
Contributor

@nojaf nojaf commented Jul 16, 2023

Of course the first time I wanted to try out the new code fix, my use-case was not yet supported 😸.

WHAT

🤖 Generated by Copilot at 623f4bc

This pull request improves the code fix for converting printf-style formatting to interpolated strings in F#. It fixes a bug with decimal format specifiers and adds a test case for it.

🤖 Generated by Copilot at 623f4bc

sprintf to string
decimal format with dot
autumn code cleanup

🌟🔧🧪

WHY

HOW

🤖 Generated by Copilot at 623f4bc

  • Update specifierRegex to support decimal format specifiers (link)
  • Add test case for code fix with dot in format specifier (link)
  • Improve readability and type-safety of printf-style formatting by converting to interpolated strings (link, link)

@TheAngryByrd TheAngryByrd merged commit 2352905 into ionide:main Jul 16, 2023
@TheAngryByrd
Copy link
Member

Thanks! 🎸

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants