Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

offer "generate xml documentation" to properties with explicit getter/setter #1126

Merged
merged 1 commit into from
Jul 1, 2023

Conversation

dawedawe
Copy link
Contributor

@dawedawe dawedawe commented Jul 1, 2023

…/setter

WHAT

🤖 Generated by Copilot at cc258f7

This pull request enhances the code fix for adding documentation comments to properties with explicit getters or setters. It updates the findNested function in src/FsAutoComplete.Core/Commands.fs to handle long identifier patterns, and adds new test cases in test/FsAutoComplete.Tests.Lsp/CodeFixTests/Tests.fs to verify the functionality.

🤖 Generated by Copilot at cc258f7

findNested expands
to handle long properties
autumn of comments

📝🔧🧪

WHY

Greetings from the live session of Amplifying F# in Bingen :)
This fixes the "Generate XML Documentation" codefix/command to be also offered for type properties with explicit getter/setter

HOW

🤖 Generated by Copilot at cc258f7

  • Add code fix for adding documentation comments to properties with explicit getters or setters (link)
  • Add test cases for the code fix in test/FsAutoComplete.Tests.Lsp/CodeFixTests/Tests.fs (link)

@baronfel
Copy link
Contributor

baronfel commented Jul 1, 2023

Hello Bingen from Texas! Thank you for this enhancement. Let's get this merged and included into today's release :)

@baronfel baronfel merged commit 95fa929 into ionide:main Jul 1, 2023
@dawedawe dawedawe deleted the af_in_bingen branch July 1, 2023 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants