RoslynSource Text #1123
Merged
RoslynSource Text #1123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faster at individual lines than Roslyn SourceText but slower at whole file creation
TheAngryByrd
force-pushed
the
own-source-text-impl
branch
2 times, most recently
from
16995ae to
b9e8693
Compare
TheAngryByrd
force-pushed
the
own-source-text-impl
branch
3 times, most recently
from
08f7117 to
986231a
Compare
TheAngryByrd
force-pushed
the
own-source-text-impl
branch
from
986231a to
79ef7cc
Compare
TheAngryByrd
commented
Jun 27, 2023
| open FSharp.UMX | ||
| open System.Collections.Generic | ||
|
|
||
| let fileContents = IO.File.ReadAllText(@"C:\Users\jimmy\Repositories\public\TheAngryByrd\span-playground\Romeo and Juliet by William Shakespeare.txt") |
There was a problem hiding this comment.
Using this a just a giant text file. Should I include it or leave as an exercise for the others?
| Microsoft.CodeAnalysis.Text.TextSpan(startPosition, endPosition - startPosition) | ||
|
|
||
| /// A SourceText with operations commonly used in FsAutocomplete | ||
| type IFSACSourceText = |
There was a problem hiding this comment.
Extracted interface for FSAC's source text impl
| static member Create(path: string<LocalPath>, text, version) = | ||
| let touched = | ||
| let path = UMX.untag path | ||
| type ISourceTextFactory = |
There was a problem hiding this comment.
Interface for pivoting between implementations.
|
|
||
| override _.GetHashCode() = |
There was a problem hiding this comment.
Taken from Fsharp repo
Comment on lines
+59
to
+62
| let sourceTextFactories: (string * ISourceTextFactory) list = [ | ||
| "NamedText", NamedTextFactory() | ||
| "RosylinSourceText", RoslynSourceTextFactory() | ||
| ] |
There was a problem hiding this comment.
Running tests for both SourceText implementations
TheAngryByrd
force-pushed
the
own-source-text-impl
branch
from
4ab4c7e to
744c2e9
Compare
TheAngryByrd
force-pushed
the
own-source-text-impl
branch
from
744c2e9 to
d2469dc
Compare
TheAngryByrd
force-pushed
the
own-source-text-impl
branch
from
d2469dc to
0e06921
Compare
|
Formatting check is failing due to a bug in fantomas: fsprojects/fantomas#2914 |
baronfel
approved these changes
Jun 30, 2023
Yeah I gotta make an ionide side flag. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
🤖 Generated by Copilot at a6a0682
Refactor
AdaptiveFSharpLspServerto useIFSACSourceTextinterface for source text representation and improve readability.🤖 Generated by Copilot at a6a0682
🔧📝🚀
WHY
This uses the SourceText from the
Microsoft.CodeAnalysispackage. The Visual Studio tooling uses this. The implementation here tends to give more favorable results when it comes to memory usage and reducing Large Object Heap allocations.I also have a very bespoke implementation I attempted awhile ago with FSharp.Data.Adaptive and handrolling a lot of text manipulation using Spans. This probably will get removed before this PR is ready.
Below are some of the benchmarks.
Nrefers to the number of changes to a text file.This does seem like a win. It allocates about 25% less though it does report slower for lots of rapid changes.
Also after running
dotnet-trace collect -p <pid> --duration 00:00:30 --profile gc-verboseand playing around with large files, we tend to not get hit with as many Large Object Heap issues.Things left to do:
HOW
🤖 Generated by Copilot at a6a0682
IFSACSourceTextinstead of the typeNamedTextin various functions, to allow different implementations for different editors or scenarios (link, link, link)namedTextbinding in thehandlerfunction inAdaptiveFSharpLspServer.fs, to make the code more consistent and readable (link, link, link, link, link, link, link)