Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fcs 43 7 300 #1116

Merged
merged 31 commits into from
Jun 10, 2023
Merged

Update fcs 43 7 300 #1116

merged 31 commits into from
Jun 10, 2023

Conversation

TheAngryByrd
Copy link
Member

@TheAngryByrd TheAngryByrd commented Jun 9, 2023

WHAT

🤖 Generated by Copilot at e5453e5

Updated the project to use the latest F# compiler version and fixed some cross-platform and test issues. Added a ChangeExtensionShim method to FileSystem.fs and updated some AST cases in UntypedAstUtils.fs and UnionPatternMatchCaseGenerator.fs. Fixed a line number error in CompletionTests.fs.

🤖 Generated by Copilot at e5453e5

FileSystem shim
Cross-platform extension fix
Autumn compatibility

📁🔧🆙

WHY

FCS 43.7.300 has been available for a bit.

Merge from the last commit that deal with 43.7.300-*

HOW

🤖 Generated by Copilot at e5453e5

  • Updated the FSharp.Compiler.Service dependency to version 43.7.300 to match the latest F# compiler release (link)
  • Removed the unnecessary FSharp.Core dependency to avoid potential conflicts (link)
  • Added a cross-platform ChangeExtensionShim method to the FileSystem type to wrap the Path.ChangeExtension function (link)
    • SynExpr.DiscardAfterMissingQualificationAfterDot, which added a new argument for the missing identifier (link, link)
    • SynExpr.AnonRecd, which added a new argument for the trivia associated with the anonymous record expression (link)
    • SynMemberDefn.ImplicitCtor, which added a new argument for the trivia associated with the implicit constructor definition (link)
  • Fixed the line number for the Position field of the completionParams value in the CompletionTests.fs file to match the test case (link)

@TheAngryByrd TheAngryByrd marked this pull request as ready for review June 9, 2023 21:56
@TheAngryByrd TheAngryByrd requested a review from baronfel June 9, 2023 21:56
@baronfel
Copy link
Contributor

Thanks for finding the appropriate spot :)

@baronfel baronfel merged commit ba1a02f into ionide:main Jun 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants