Reduced memory consumption of autocompletion cache #1077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheAngryByrd
commented
Mar 14, 2023
| @@ -36,7 +36,7 @@ type FSharpCompilerServiceChecker(hasAnalyzers) = | |||
| // This is used to hold previous check results for autocompletion. | |||
| // We can't seem to rely on the checker for previous cached versions | |||
| let memoryCache () = | |||
| new MemoryCache(MemoryCacheOptions(SizeLimit = Nullable<_>(2000L))) | |||
| new MemoryCache(MemoryCacheOptions(SizeLimit = Nullable<_>(200L))) | |||
There was a problem hiding this comment.
200 might still be too much. Someone could edit 200 files within 5 minutes and want autocompletions for them all but seems unlikely.
There was a problem hiding this comment.
nit - surface as a config option? maybe something like FSharp.fsac.cachedTypeCheckCount?
This lets the caller of ParseAndCheckFileInProject determine if it should cache type checks for autocompletions. Typically we don't want to store them for anything other the already open files.
TheAngryByrd
force-pushed
the
reduce-memory-usage
branch
from
aeef1ff to
dc66178
Compare
baronfel
approved these changes
Mar 14, 2023
| @@ -36,7 +36,7 @@ type FSharpCompilerServiceChecker(hasAnalyzers) = | |||
| // This is used to hold previous check results for autocompletion. | |||
| // We can't seem to rely on the checker for previous cached versions | |||
| let memoryCache () = | |||
| new MemoryCache(MemoryCacheOptions(SizeLimit = Nullable<_>(2000L))) | |||
| new MemoryCache(MemoryCacheOptions(SizeLimit = Nullable<_>(200L))) | |||
There was a problem hiding this comment.
nit - surface as a config option? maybe something like FSharp.fsac.cachedTypeCheckCount?
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, on save, we would cache all typechecks. This could cause large solutions to use a lot of memory for no real purpose. This lets the caller of ParseAndCheckFileInProject determine if it should cache type checks for autocompletions. Typically we don't want to store them for anything other the already open files.