Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

This is fix for invalid header from cache that led to desynchronizati… #39

Merged
merged 1 commit into from
Nov 18, 2020
Merged

This is fix for invalid header from cache that led to desynchronizati… #39

merged 1 commit into from
Nov 18, 2020

Conversation

blazejkrzak
Copy link

@blazejkrzak blazejkrzak commented Nov 18, 2020 •
edited
Loading

Backstory:
Reopening from another solution branch: #34

Issue scenario -

  1. geth nodes with one validator
  2. node0 was only validator in this scenario
  3. started two nodes node0 and node1 successfully and they get peers.
  4. After that, node1 started mining but it failed to mine because node0 was the validator.
  5. Then node0 started mining and announced block 1 but node1 failed to verify the block 1. Given error - unknown ancestor

@blazejkrzak blazejkrzak linked an issue Nov 18, 2020 that may be closed by this pull request
Fix invalid header from cache #40
Closed
@blazejkrzak blazejkrzak self-assigned this Nov 18, 2020
@blazejkrzak blazejkrzak added the bug Something isn't working label Nov 18, 2020
@blazejkrzak blazejkrzak added this to the AuthorityRound Engine milestone Nov 18, 2020
@blazejkrzak blazejkrzak merged commit 8c68e04 into epic/aura-consensus Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxmar mxmar mxmar approved these changes

@atif-konasl atif-konasl Awaiting requested review from atif-konasl

@patred20 patred20 Awaiting requested review from patred20

Assignees

@blazejkrzak blazejkrzak

Labels
bug Something isn't working
Projects
None yet
Milestone
AuthorityRound Engine
Development

Successfully merging this pull request may close these issues.

Fix invalid header from cache
2 participants
@blazejkrzak @mxmar