Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify session to use HTTPAdapter and handle retries #324

Merged
merged 1 commit into from
Jul 2, 2020
Merged

Conversation

fronzbot
Copy link
Owner

@fronzbot fronzbot commented Jul 2, 2020

Description:

Adds automatic retry on failures and throttling

Checklist:

  • Local tests with tox run successfully PR cannot be meged unless tests pass
  • Changes tested locally to ensure platform still works as intended
  • Tests added to verify new code works

@codecov
Copy link

codecov bot commented Jul 2, 2020

Codecov Report

Merging #324 into dev will increase coverage by 0.14%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #324      +/-   ##
==========================================
+ Coverage   82.75%   82.90%   +0.14%     
==========================================
  Files           8        8              
  Lines         928      936       +8     
==========================================
+ Hits          768      776       +8     
  Misses        160      160              
Flag Coverage Δ
#unittests 82.90% <100.00%> (+0.14%) ⬆️
Impacted Files Coverage Δ
blinkpy/auth.py 95.10% <100.00%> (+0.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6dc22f...a030f46. Read the comment docs.

@fronzbot fronzbot merged commit 391373b into dev Jul 2, 2020
@fronzbot fronzbot deleted the http-adapter branch July 2, 2020 18:36
@fronzbot fronzbot mentioned this pull request Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant