Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed missing sync module arm method #299

Merged
merged 1 commit into from
Jun 10, 2020
Merged

Fixed missing sync module arm method #299

merged 1 commit into from
Jun 10, 2020

Conversation

fronzbot
Copy link
Owner

Description:

Add sync module arm and disarm methods back since they were inadvertently removed in the last rc release

Related issue (if applicable): fixes #298

Checklist:

  • Local tests with tox run successfully PR cannot be meged unless tests pass
  • Changes tested locally to ensure platform still works as intended
  • Tests added to verify new code works

@codecov
Copy link

codecov bot commented Jun 10, 2020

Codecov Report

Merging #299 into dev will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #299   +/-   ##
=======================================
  Coverage   82.09%   82.09%           
=======================================
  Files           8        8           
  Lines         899      899           
=======================================
  Hits          738      738           
  Misses        161      161           
Flag Coverage Δ
#unittests 82.09% <0.00%> (ø)
Impacted Files Coverage Δ
blinkpy/sync_module.py 86.91% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c56c90...b73d122. Read the comment docs.

@fronzbot fronzbot merged commit c4b70f9 into dev Jun 10, 2020
@fronzbot fronzbot deleted the fix-sync-arm branch June 10, 2020 14:13
@fronzbot fronzbot mentioned this pull request Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sync modules cannot be armed/disarmed
1 participant