Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify Directions to Dynamically Include libgit2 #3821

Open
merichar opened this issue May 5, 2021 · 0 comments · May be fixed by #3822
Open

Clarify Directions to Dynamically Include libgit2 #3821

merichar opened this issue May 5, 2021 · 0 comments · May be fixed by #3822

Comments

@merichar
Copy link

merichar commented May 5, 2021

Problem

The current comment in phoenix.pro says:

# Disable this if you have (and want) libgit2 dynamically
LIBGIT_STATIC = true

It's ambiguous and some folks are going to comment this out instead of setting it to false, which leads to the qmake error:

libgit2detect.pri:22: if(condition) requires one argument.

Proposed Solution

To save other folks some time, let's just rephrase it to:

# Set this to false if you have (and want) libgit2 dynamically
LIBGIT_STATIC = true
@merichar merichar linked a pull request May 5, 2021 that will close this issue
Open
@janclod janclod mentioned this issue Aug 15, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clarify Dynamic libgit2 Instructions merichar/fritzing-app
1 participant
@merichar