-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for alphanumeric short code SMS phone numbers #475
Comments
Hello @brenard The main change would be in PAssist itself. The android contact application does not allow to use alphanumeric numbers as phone numbers. Somewhere it would be necessary to store the number of the company, maybe in an additional field of the contact or in PAssist itself. If my first question can be answered with yes, I guess such a change is possible with a reasonable effort. |
No, it's not possible to answer to this type of message (SMS apps disable the reply for this type of message).
It's seem not possible to store this type of contact (SMS apps seem not offer this feature), so a field in PAssist to store the contact name would be great (or why not a regex for contacts name if it's not too complex).
As explain, it's not possible to reply to this type of messages and I don't known what happen if you try. If you want, I can send you one of this type of SMS (just send me a phone in a private message). |
I guess the company field in the contact could be used to store this kind of company number. Do you use PAssist already? Does your alerting system not require a confirmation reply? I can prepare a PR to support that. But for testing I would require some help from your side. As a preparation it would be great to get such an SMS with a company number to my phone. |
If you fine a way, it's could be great.
Yes, I use it since one year may be. Our alerting system does not require reply, we have to ack alerts directly by using its Web interface.
Of course! Say me if I could help you.
Sent! |
I did some experiments. Looks all doable. |
Awesome! Let me known if you need tests. |
The implementation is completed so far. I was able to test alphanumeric short codes on the android-simulator. Therefore I'm quite confident that it should work also end to end on real devices. As soon as the new version 2.10.0 pops-up in Goole-Play or IzzyOnDroid, I would be very happy if you @brenard could make some tests with real alphanumeric short code SMS. Looking forward to hear about your test results. |
Of course, I will try! Many thanks! |
After upgrading the 2 apps, I tried to configure I noted that Easter-eggs does not appear with other numbers in S2MSP. It's normal? I also try to reconfigure the operations center contact but it does not change anything. Finally, I try to create a new contact with just If you want I can send you another real sms with this name as sender. |
Workaround for now: Can you try this and let me know? |
My workaround from last comment does not work when I create a new contact. |
My first try was with my existing contact with 3 real phone numbers : I just added the company name but it does not appear in S2MSP and SMS do not triggered passist. I also try to choose another contact in passist, removed the previous authorization in S2MSP, select back the contact in passist and add the authorization from passist home page in S2MSP, but it does not work and the organization name does not appear in S2MSP. If you reproduce a problem, may be your fix will also solve my problem. Wait and see! Many thanks! |
Both problems 1 and 2 were related to an improper content resolver query not selecting the contacts company name for some contacts. |
With the latest release, all works great! I just noted one thing : when switching to a new contact, the phone numbers of the old contact are keeped as granted in S2MSP. It not really important, because a SMS sent by the old phone number does not trigger passist. May be you could cleanup old granted phone numbers when configuring new ones. Many thanks for this changes! |
Thank you @brenard for your feedback. I'm happy that it works - at least in the second round 😉
The rational behind this intended behavior is, that in the view of PAssist the granting of numbers is only a burden. As you said, for the function of PAssist it has no impact if more than the used numbers are granted. |
I give you a star on Github, of course, but I installed PAssist from IzzyOnDroid so I guest I can't put a review on it on Google Play store. |
Hello,
Due to legislation change, it's quite difficult to send SMS from France with a dedicated/fixed sender phone number without restrictions (currently 100 SMS per hour, 1000 SMS per day but it could change in coming months). The legislation wants to force companies to send SMS using short numbers (3XXXX, usually random), numbers in 09 or with the name of the company as the sender. There is not yet a number in 09 dedicated to this subject and the providers therefore do not yet have any to rent.
It could be very practical that PAssist supports SMS sent with the name of the company as the sender : No more need of dedicated numbers and large choice of providers. I imagine that this would also require an evolution on the S2MSP side.
Do you think this would be possible?
Thanks!
The text was updated successfully, but these errors were encountered: