Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to deal with C4251 warning #2

Open
friendlyanon opened this issue Apr 14, 2021 · 3 comments
Open

How to deal with C4251 warning #2

friendlyanon opened this issue Apr 14, 2021 · 3 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@friendlyanon
Copy link
Owner

friendlyanon commented Apr 14, 2021

https://stackoverflow.com/a/22054743 gives a good summary for possible remedies.

PIMPL seems to be the best option, but is that really a good concept to have in an init script targeting mainly beginners?
Need to think about this.

@friendlyanon friendlyanon added enhancement New feature or request help wanted Extra attention is needed labels Apr 14, 2021
@friendlyanon
Copy link
Owner Author

friendlyanon commented May 4, 2021

Another option that I came across is wrapping the library exports in a C API with a header-only library component on top to provide a usable C++ API. Consequently, this is also a method to mix binaries created with different compilers, compile flags and ABI.

@friendlyanon
Copy link
Owner Author

I have pushed 7bca880 disabling this warning and with an explanation in the header file template of the shared library.

@friendlyanon
Copy link
Owner Author

@satya-das has a WIP solution called cib, which generates an hourglass interface similar to what was described by @sdutoit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant