Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve library import speed #118

Closed
roll opened this issue Oct 12, 2016 · 4 comments · Fixed by frictionlessdata/tabulator-py#107
Closed

Improve library import speed #118

roll opened this issue Oct 12, 2016 · 4 comments · Fixed by frictionlessdata/tabulator-py#107

Comments

@roll
Copy link
Member

roll commented Oct 12, 2016

From my tests it will take around 1s:

import jsontableschema
@pwalsh
Copy link
Member

pwalsh commented Oct 12, 2016

why?

@roll
Copy link
Member Author

roll commented Oct 12, 2016

I don't know) I'll profile. There are a few chunks of code which runs outside of functions and classes. But also may be it's normal because of dependencies. Juts discovered it because GT time to create a report for simple dataset could be around 10-100ms but overall around 2s and most of them on jsontableschema import.

@Fak3
Copy link

Fak3 commented Oct 31, 2016

The tabulator import is instant after the fix. But the jsontableschema is still slow to import... ;( I guess it was not only affected by tabulator, but has issue itself. Can you please have a look?

@roll roll reopened this Nov 1, 2016
@roll roll added [1d] labels Dec 15, 2016
@roll roll added (py) and removed (py) labels Jan 16, 2017
@roll roll removed the [1d] label Feb 25, 2017
@roll roll removed the planned label Mar 20, 2017
@roll roll removed this from the Version-1 milestone Mar 20, 2017
@roll roll removed their assignment Mar 20, 2017
@roll roll changed the title Slow import speed Improve library import speed Aug 18, 2017
@roll
Copy link
Member Author

roll commented Sep 4, 2017

FIXED
Latest tests just show not it's around normal (200ms). It still needs to read profiles from a disc.

@roll roll closed this as completed Sep 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants