Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set minimum R dep to R3.6.0 (originally R4.0 was suggested) #238

Closed
3 tasks done
PietrH opened this issue Jul 9, 2024 · 1 comment · Fixed by #245
Closed
3 tasks done

Set minimum R dep to R3.6.0 (originally R4.0 was suggested) #238

PietrH opened this issue Jul 9, 2024 · 1 comment · Fixed by #245
Assignees

Comments

@PietrH
Copy link
Member

PietrH commented Jul 9, 2024

Context: #235

We've decided to up the minimum dependency to R4.0.0, so we can use native pipes and to follow the tidyverse policy: https://www.tidyverse.org/blog/2019/04/r-version-support/

In the discussion I linked to in #235 for the evaluate package, Hadley Wickam decides to set the minimum requirement there as R4.0.0, but then later on changes his mind back to R3.6, which is what it currently is for the dev version.

The packages that are dependencies of testthat will continue working on R3.6 minimum, the other tidyverse packages will soon change to R4.0 minimum.

So the reasoning is that we go to R4.0 minimum to stay in line with the tidyverse.

  • Update DESCRIPTION
  • Create CI action
  • Remove usage of ...names()
@PietrH PietrH self-assigned this Jul 9, 2024
@PietrH PietrH changed the title Set minimum R dep to R4.1.0 Set minimum R dep to R4.0 Jul 9, 2024
@PietrH PietrH linked a pull request Jul 9, 2024 that will close this issue
@peterdesmet
Copy link
Member

Since frictionless is designed as a dependency for other packages, it's likely good to support as many versions of R as possible. bioRad for example, which depends on frictionless, has Depends: R (>= 3.5.0) https://github.com/adokter/bioRad/blob/65fbeb0e22090d968c2d9657b1e2e3da2499a45b/DESCRIPTION#L29

The (likely) only reason we have to bump to 4.0.0 is because of the evaluate package. A recent update to that package however, will restore R3.6.0 functionality, so I think we can stick to that too.

#245 implements this:

  • Sets minimum version to 3.6.0
  • Tests for that version as a GH action
  • Has a helper function instead of ...names() which was only released in R4.0.0

Currently the #245 fails because:

* evaluate: Needs R >= 4.0.0

Once evaluate > 0.24.0 is released, we should retry the tests for #245. This PR:

@peterdesmet peterdesmet changed the title Set minimum R dep to R4.0 Set minimum R dep to ~R4.0~ R3.6.0 Jul 10, 2024
@peterdesmet peterdesmet changed the title Set minimum R dep to ~R4.0~ R3.6.0 Set minimum R dep to ~~R4.0~~ R3.6.0 Jul 10, 2024
@peterdesmet peterdesmet changed the title Set minimum R dep to ~~R4.0~~ R3.6.0 Set minimum R dep to R3.6.0 (originally R4.0 was suggested) Jul 10, 2024
@peterdesmet peterdesmet mentioned this issue Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants