Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: replace conditionalstats addition with condensed substats, fix min stat filter precision #254

Merged
merged 6 commits into from
Apr 3, 2024
Merged

feat: replace conditionalstats addition with condensed substats, fix min stat filter precision #254

merged 6 commits into from
Apr 3, 2024

Conversation

fribbels
Copy link
Owner

@fribbels fribbels commented Apr 3, 2024 •
edited
Loading

Pull Request

Description

  • Replacing summing augmentedStats with a condensed version of substats
    • Performance increase for non-filtered searches on everything but firefox
  • Increase block size 100,000 -> 150,000
    • Performance increase
  • Added 0.000001 to all c stats in optimizer, to adjust for floating point errors when using min-filters
  • Save stat filters to 1000th precision

Related Issue

Checklist

  • I have added commit messages that are descriptive and meaningful.
  • I have tested the changes locally.
  • I have reviewed the code changes.

Screenshots

@fribbels fribbels changed the title feat: replace conditionalstats addition with condensed substats feat: replace conditionalstats addition with condensed substats, fix min stat filter precision Apr 3, 2024
@fribbels fribbels merged commit 24609f0 into beta Apr 3, 2024
1 check passed
@fribbels fribbels deleted the feature/substat-addition branch April 3, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@fribbels