Skip to content

Commit

Permalink
Pin websockets library
Browse files Browse the repository at this point in the history
Set upper bound for websockets until libjuju is compatible with newer
versions.

See juju/python-libjuju#1208
  • Loading branch information
freyes committed Nov 25, 2024
1 parent bef1bdb commit 05ca758
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 0 deletions.
4 changes: 4 additions & 0 deletions requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -35,3 +35,7 @@ sphinx
sphinxcontrib-asyncio
# https://github.com/go-macaroon-bakery/py-macaroon-bakery/issues/94
macaroonbakery!=1.3.3

# NOTE(freyes): Set upper bound for websockets until libjuju is compatible with
# newer versions. See https://github.com/juju/python-libjuju/pull/1208
websockets<13.0.0
3 changes: 3 additions & 0 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,9 @@

# https://github.com/go-macaroon-bakery/py-macaroon-bakery/issues/94
'macaroonbakery != 1.3.3',
# NOTE(freyes): Set upper bound for websockets until libjuju is compatible
# with newer versions. See https://github.com/juju/python-libjuju/pull/1208
'websockets<13.0.0',
]
if os.environ.get("TEST_JUJU3"):
install_require.append('juju')
Expand Down
4 changes: 4 additions & 0 deletions test-requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,10 @@ keystoneauth1
oslo.config
python-novaclient
tenacity>8.2.0
# NOTE(freyes): Set upper bound for websockets until libjuju is compatible with
# newer versions. See https://github.com/juju/python-libjuju/pull/1208
websockets<13.0.0

# To force the installation of an specific version of libjuju use a constraints
# file, e.g.: `env PIP_CONSTRAINTS=./constraints-juju31.txt tox -e func-target`
juju
Expand Down

0 comments on commit 05ca758

Please sign in to comment.