Add version flag #121
Merged
Add version flag #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
schnapster
commented
Jun 25, 2018
schnapster
commented
- Add CLI flag to print version information and exit
- Print more version information on start
- Print banner and version info into the log, not just standard out
- Log errors more reliably during spring application start
freyacodes
requested changes
Jun 27, 2018
| || args[0].equalsIgnoreCase("--version"))) { | ||
| System.out.println("Version flag detected. Printing version info, then exiting."); | ||
| System.out.println(getVersionInfo()); | ||
| System.out.println("Version info printed, exiting."); |
There was a problem hiding this comment.
These two other prints seem unnecessary, especially since having two makes them redundant.
There was a problem hiding this comment.
If you are using the version flag, you should expect this to exit as it is common practice. I don't see a case where this would actually be useful
There was a problem hiding this comment.
Brain was afk there ;)
- Add CLI flag to print version information and exit - Print more version information on start - Print banner and version info into the log, not just standard out - Log errors more reliably during spring application start
schnapster
force-pushed
the
feature/version-flag
branch
from
ff3d3a5 to
db91063
Compare
freyacodes
approved these changes
Jun 27, 2018
freyacodes
pushed a commit
to freyacoded/repo-test
that referenced
this pull request
Oct 11, 2022
- Add CLI flag to print version information and exit - Print more version information on start - Print banner and version info into the log, not just standard out - Log errors more reliably during spring application start
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.