Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSRV policy #24

Open
parasyte opened this issue Dec 6, 2022 · 2 comments
Open

MSRV policy #24

parasyte opened this issue Dec 6, 2022 · 2 comments
Labels
help wanted Extra attention is needed

Comments

@parasyte
Copy link

parasyte commented Dec 6, 2022

I ran into an issue with an old version of the compiler installed on Linux which caused an arcane error message to appear. And it took an unusually long time to diagnose and fix the error (update the compiler).

Repro steps:

$ rustup toolchain install 1.59.0

$ cargo +1.59.0 build
    Updating crates.io index
error: failed to select a version for the requirement `zbus = "^3.0"`
candidate versions found which didn't match: 2.3.2, 2.3.1, 2.3.0, ...
location searched: crates.io index
required by package `dark-light v0.2.3 (/home/jay/other-projects/rust-dark-light)`

zbus 3 requires at least Rust 1.60.0. What is your position on a Minimum Supported Rust Version (MSRV) policy? I don't see any such policy in the repo right now.

@frewsxcv
Copy link
Owner

frewsxcv commented Dec 6, 2022

We should add one, and it should probably be 1.60.0 if that's what zbus requires

@frewsxcv frewsxcv added the help wanted Extra attention is needed label Dec 6, 2022
@Be-ing
Copy link
Collaborator

Be-ing commented Dec 6, 2022

I've seen other Rust projects have CI jobs for both the MSRV and stable Rust.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants