From babc58ddc94c2b5f4905e9a745f4ec094beeeaf3 Mon Sep 17 00:00:00 2001 From: kanalveli R A Date: Tue, 14 Jul 2020 16:46:23 +0530 Subject: [PATCH] [FD-59231] fix: Add missing nucleus-icons + banner changes (#197) --- packages/@nucleus/tests/dummy/app/constants/icons.js | 4 +++- .../icon/public/assets/icons/nucleus-circle-check.svg | 4 +--- packages/icon/public/assets/icons/nucleus-circle-info.svg | 8 +------- .../icon/public/assets/icons/nucleus-circle-warning.svg | 1 + packages/icon/public/assets/icons/nucleus-danger.svg | 1 + .../addon/constants/nucleus-inline-banner.js | 6 +++--- 6 files changed, 10 insertions(+), 14 deletions(-) create mode 100644 packages/icon/public/assets/icons/nucleus-circle-warning.svg create mode 100644 packages/icon/public/assets/icons/nucleus-danger.svg diff --git a/packages/@nucleus/tests/dummy/app/constants/icons.js b/packages/@nucleus/tests/dummy/app/constants/icons.js index 96c073ab..e19ceb1a 100644 --- a/packages/@nucleus/tests/dummy/app/constants/icons.js +++ b/packages/@nucleus/tests/dummy/app/constants/icons.js @@ -5,6 +5,8 @@ export default [ "nucleus-circle-info", "nucleus-circle-minus", "nucleus-circle-plus", + "nucleus-circle-warning", "nucleus-cross-thin", - "nucleus-cross" + "nucleus-cross", + "nucleus-danger" ]; \ No newline at end of file diff --git a/packages/icon/public/assets/icons/nucleus-circle-check.svg b/packages/icon/public/assets/icons/nucleus-circle-check.svg index 19282dac..4326f836 100644 --- a/packages/icon/public/assets/icons/nucleus-circle-check.svg +++ b/packages/icon/public/assets/icons/nucleus-circle-check.svg @@ -1,3 +1 @@ - - - +circle-check \ No newline at end of file diff --git a/packages/icon/public/assets/icons/nucleus-circle-info.svg b/packages/icon/public/assets/icons/nucleus-circle-info.svg index 933b1c61..e23ebdf8 100644 --- a/packages/icon/public/assets/icons/nucleus-circle-info.svg +++ b/packages/icon/public/assets/icons/nucleus-circle-info.svg @@ -1,7 +1 @@ - - - - - - - +info \ No newline at end of file diff --git a/packages/icon/public/assets/icons/nucleus-circle-warning.svg b/packages/icon/public/assets/icons/nucleus-circle-warning.svg new file mode 100644 index 00000000..595fe6db --- /dev/null +++ b/packages/icon/public/assets/icons/nucleus-circle-warning.svg @@ -0,0 +1 @@ + \ No newline at end of file diff --git a/packages/icon/public/assets/icons/nucleus-danger.svg b/packages/icon/public/assets/icons/nucleus-danger.svg new file mode 100644 index 00000000..d1d8c200 --- /dev/null +++ b/packages/icon/public/assets/icons/nucleus-danger.svg @@ -0,0 +1 @@ +alert \ No newline at end of file diff --git a/packages/inline-banner/addon/constants/nucleus-inline-banner.js b/packages/inline-banner/addon/constants/nucleus-inline-banner.js index f6d9d538..6d96293c 100644 --- a/packages/inline-banner/addon/constants/nucleus-inline-banner.js +++ b/packages/inline-banner/addon/constants/nucleus-inline-banner.js @@ -1,8 +1,8 @@ const ICON_MAP = { - 'info': 'nucleus-circle-help', + 'info': 'nucleus-circle-info', 'success': 'nucleus-circle-check', - 'warning': 'nucleus-circle-info', - 'danger': 'nucleus-circle-cross' + 'warning': 'nucleus-circle-warning', + 'danger': 'nucleus-danger' }; export { ICON_MAP }; \ No newline at end of file