From a0239a8a88011cf00ba4617122e3d288da81a08a Mon Sep 17 00:00:00 2001 From: Shibu Lijack Date: Sat, 11 Jan 2020 11:00:09 +0530 Subject: [PATCH] fix(nucleus): removed classic decorator dependency --- packages/banner/addon/components/nucleus-banner.js | 2 -- packages/banner/addon/components/nucleus-banner/item.js | 2 -- packages/banner/package.json | 1 - packages/button/addon/components/nucleus-button.js | 2 -- packages/button/package.json | 1 - packages/icon/addon/components/nucleus-icon.js | 3 +-- packages/icon/package.json | 1 - .../addon/components/nucleus-inline-banner.js | 2 -- packages/inline-banner/package.json | 1 - packages/modal/addon/components/nucleus-confirm-dialog.js | 2 -- packages/modal/addon/components/nucleus-modal.js | 2 -- packages/modal/addon/components/nucleus-modal/body.js | 2 -- packages/modal/addon/components/nucleus-modal/dialog.js | 2 -- packages/modal/addon/components/nucleus-modal/footer.js | 2 -- packages/modal/addon/components/nucleus-modal/header.js | 2 -- packages/modal/addon/components/nucleus-slider.js | 2 -- packages/modal/package.json | 1 - .../addon/components/nucleus-toast-message.js | 2 -- packages/toast-message/package.json | 1 - yarn.lock | 8 -------- 20 files changed, 1 insertion(+), 40 deletions(-) diff --git a/packages/banner/addon/components/nucleus-banner.js b/packages/banner/addon/components/nucleus-banner.js index 93c21987..5ad6c786 100644 --- a/packages/banner/addon/components/nucleus-banner.js +++ b/packages/banner/addon/components/nucleus-banner.js @@ -1,4 +1,3 @@ -import classic from 'ember-classic-decorator'; import { layout as templateLayout } from '@ember-decorators/component'; import defaultProp from '@freshworks/core/utils/default-decorator'; import { observes } from '@ember-decorators/object'; @@ -17,7 +16,6 @@ import { action, computed } from '@ember/object'; @extends Ember.Component @public */ -@classic @templateLayout(layout) class NucleusBanner extends Component { /** diff --git a/packages/banner/addon/components/nucleus-banner/item.js b/packages/banner/addon/components/nucleus-banner/item.js index e326a01a..51a4c2da 100644 --- a/packages/banner/addon/components/nucleus-banner/item.js +++ b/packages/banner/addon/components/nucleus-banner/item.js @@ -1,4 +1,3 @@ -import classic from 'ember-classic-decorator'; import { tagName, layout as templateLayout } from '@ember-decorators/component'; import { reads } from '@ember/object/computed'; import Component from '@ember/component'; @@ -12,7 +11,6 @@ import { ICON_MAP } from '../../constants/nucleus-banner'; @extends Ember.Component @public */ -@classic @templateLayout(layout) @tagName('') class Item extends Component { diff --git a/packages/banner/package.json b/packages/banner/package.json index 91b6d687..43af5bc2 100644 --- a/packages/banner/package.json +++ b/packages/banner/package.json @@ -25,7 +25,6 @@ "@freshworks/button": "^0.3.0", "@freshworks/core": "^0.1.5", "@freshworks/icon": "^0.3.0", - "ember-classic-decorator": "^1.0.5", "ember-cli-babel": "^7.11.1", "ember-cli-htmlbars": "^4.0.0", "ember-cli-sass": "^10.0.0", diff --git a/packages/button/addon/components/nucleus-button.js b/packages/button/addon/components/nucleus-button.js index 68b5cb32..4f180c81 100644 --- a/packages/button/addon/components/nucleus-button.js +++ b/packages/button/addon/components/nucleus-button.js @@ -1,4 +1,3 @@ -import classic from 'ember-classic-decorator'; import { classNames, attributeBindings, @@ -25,7 +24,6 @@ import { BUTTON_STATE } from "../constants/nucleus-button"; @extends Ember.Component @public */ -@classic @templateLayout(layout) @tagName('button') @classNames('nucleus-button') diff --git a/packages/button/package.json b/packages/button/package.json index 0c237f8d..fed561e6 100644 --- a/packages/button/package.json +++ b/packages/button/package.json @@ -24,7 +24,6 @@ "dependencies": { "@freshworks/core": "^0.1.5", "@freshworks/icon": "^0.3.0", - "ember-classic-decorator": "^1.0.5", "ember-cli-babel": "^7.11.1", "ember-cli-htmlbars": "^4.0.0", "ember-cli-sass": "^10.0.0", diff --git a/packages/icon/addon/components/nucleus-icon.js b/packages/icon/addon/components/nucleus-icon.js index 62a27ff5..6d471573 100644 --- a/packages/icon/addon/components/nucleus-icon.js +++ b/packages/icon/addon/components/nucleus-icon.js @@ -1,4 +1,3 @@ -import classic from 'ember-classic-decorator'; import { tagName, layout as templateLayout, @@ -17,7 +16,7 @@ import layout from "../templates/components/nucleus-icon"; @extends Ember.Component @public */ -@classic + @templateLayout(layout) @tagName('') class NucleusIcon extends Component { diff --git a/packages/icon/package.json b/packages/icon/package.json index 14cd2dc9..7b525b34 100644 --- a/packages/icon/package.json +++ b/packages/icon/package.json @@ -23,7 +23,6 @@ }, "dependencies": { "@freshworks/core": "^0.1.1", - "ember-classic-decorator": "^1.0.5", "ember-cli-babel": "^7.11.1", "ember-cli-htmlbars": "^4.0.0", "ember-cli-sass": "^10.0.0", diff --git a/packages/inline-banner/addon/components/nucleus-inline-banner.js b/packages/inline-banner/addon/components/nucleus-inline-banner.js index a7dfda1e..39b5f48e 100644 --- a/packages/inline-banner/addon/components/nucleus-inline-banner.js +++ b/packages/inline-banner/addon/components/nucleus-inline-banner.js @@ -1,4 +1,3 @@ -import classic from 'ember-classic-decorator'; import defaultProp from '@freshworks/core/utils/default-decorator'; import { classNames, attributeBindings, classNameBindings, layout as templateLayout } from '@ember-decorators/component'; import Component from '@ember/component'; @@ -17,7 +16,6 @@ import { ICON_MAP } from '../constants/nucleus-inline-banner'; @extends Ember.Component @public */ -@classic @templateLayout(layout) @classNames('nucleus-inline-banner') @classNameBindings('_typeClass', '_isOpen:show:hide') diff --git a/packages/inline-banner/package.json b/packages/inline-banner/package.json index 0efd3cd3..bb0bd172 100644 --- a/packages/inline-banner/package.json +++ b/packages/inline-banner/package.json @@ -25,7 +25,6 @@ "@freshworks/button": "^0.3.0", "@freshworks/core": "^0.1.5", "@freshworks/icon": "^0.3.0", - "ember-classic-decorator": "^1.0.5", "ember-cli-babel": "^7.11.1", "ember-cli-htmlbars": "^4.0.0", "ember-cli-sass": "^10.0.0", diff --git a/packages/modal/addon/components/nucleus-confirm-dialog.js b/packages/modal/addon/components/nucleus-confirm-dialog.js index ea7783d8..8ffaff25 100644 --- a/packages/modal/addon/components/nucleus-confirm-dialog.js +++ b/packages/modal/addon/components/nucleus-confirm-dialog.js @@ -1,4 +1,3 @@ -import classic from 'ember-classic-decorator'; import { layout as templateLayout } from '@ember-decorators/component'; import defaultProp from '@freshworks/core/utils/default-decorator'; import Modal from './nucleus-modal'; @@ -17,7 +16,6 @@ import layout from '../templates/components/nucleus-confirm-dialog'; @extends Ember.Component @public */ -@classic @templateLayout(layout) class NucleusConfirmDialog extends Modal { /** diff --git a/packages/modal/addon/components/nucleus-modal.js b/packages/modal/addon/components/nucleus-modal.js index 3b881886..bd2e141d 100644 --- a/packages/modal/addon/components/nucleus-modal.js +++ b/packages/modal/addon/components/nucleus-modal.js @@ -1,4 +1,3 @@ -import classic from 'ember-classic-decorator'; import { layout as templateLayout } from '@ember-decorators/component'; import { observes } from '@ember-decorators/object'; import defaultProp from '@freshworks/core/utils/default-decorator'; @@ -26,7 +25,6 @@ import layout from "../templates/components/nucleus-modal"; @extends Ember.Component @public */ -@classic @templateLayout(layout) class Modal extends Component { /** diff --git a/packages/modal/addon/components/nucleus-modal/body.js b/packages/modal/addon/components/nucleus-modal/body.js index bebae80e..aeecbf12 100644 --- a/packages/modal/addon/components/nucleus-modal/body.js +++ b/packages/modal/addon/components/nucleus-modal/body.js @@ -1,9 +1,7 @@ -import classic from 'ember-classic-decorator'; import { classNames, layout as templateLayout } from '@ember-decorators/component'; import Component from '@ember/component'; import layout from '../../templates/components/nucleus-modal/body'; -@classic @templateLayout(layout) @classNames('nucleus-modal__body') class Body extends Component {} diff --git a/packages/modal/addon/components/nucleus-modal/dialog.js b/packages/modal/addon/components/nucleus-modal/dialog.js index b1838bd6..711959cd 100644 --- a/packages/modal/addon/components/nucleus-modal/dialog.js +++ b/packages/modal/addon/components/nucleus-modal/dialog.js @@ -1,4 +1,3 @@ -import classic from 'ember-classic-decorator'; import { classNames, attributeBindings, classNameBindings, layout as templateLayout } from '@ember-decorators/component'; import defaultProp from '@freshworks/core/utils/default-decorator'; import { readOnly } from '@ember/object/computed'; @@ -15,7 +14,6 @@ import scroll from "../../mixins/scroll"; @extends Ember.Component @public */ -@classic @templateLayout(layout) @classNames('nucleus-modal') @classNameBindings('positionClass') diff --git a/packages/modal/addon/components/nucleus-modal/footer.js b/packages/modal/addon/components/nucleus-modal/footer.js index f5eca745..2e9b7690 100644 --- a/packages/modal/addon/components/nucleus-modal/footer.js +++ b/packages/modal/addon/components/nucleus-modal/footer.js @@ -1,4 +1,3 @@ -import classic from 'ember-classic-decorator'; import Component from '@ember/component'; import defaultProp from '@freshworks/core/utils/default-decorator'; import { classNames, tagName, classNameBindings, layout as templateLayout } from '@ember-decorators/component'; @@ -12,7 +11,6 @@ import layout from '../../templates/components/nucleus-modal/footer'; @extends Ember.Component @public */ -@classic @templateLayout(layout) @tagName('form') @classNames('nucleus-modal__footer') diff --git a/packages/modal/addon/components/nucleus-modal/header.js b/packages/modal/addon/components/nucleus-modal/header.js index 4edbd088..20dccc24 100644 --- a/packages/modal/addon/components/nucleus-modal/header.js +++ b/packages/modal/addon/components/nucleus-modal/header.js @@ -1,4 +1,3 @@ -import classic from 'ember-classic-decorator'; import { classNames, layout as templateLayout } from '@ember-decorators/component'; import defaultProp from '@freshworks/core/utils/default-decorator'; import Component from '@ember/component'; @@ -11,7 +10,6 @@ import layout from '../../templates/components/nucleus-modal/header'; @extends Ember.Component @public */ -@classic @templateLayout(layout) @classNames('nucleus-modal__header') class Header extends Component { diff --git a/packages/modal/addon/components/nucleus-slider.js b/packages/modal/addon/components/nucleus-slider.js index a3787c1e..dcf3f395 100644 --- a/packages/modal/addon/components/nucleus-slider.js +++ b/packages/modal/addon/components/nucleus-slider.js @@ -1,4 +1,3 @@ -import classic from 'ember-classic-decorator'; import { layout as templateLayout } from '@ember-decorators/component'; import defaultProp from '@freshworks/core/utils/default-decorator'; import Modal from './nucleus-modal'; @@ -17,7 +16,6 @@ import layout from '../templates/components/nucleus-slider'; @extends Ember.Component @public */ -@classic @templateLayout(layout) class NucleusSlider extends Modal { /** diff --git a/packages/modal/package.json b/packages/modal/package.json index b6506cc9..c8e00061 100644 --- a/packages/modal/package.json +++ b/packages/modal/package.json @@ -25,7 +25,6 @@ "@freshworks/button": "^0.3.0", "@freshworks/core": "^0.1.5", "@freshworks/icon": "^0.3.0", - "ember-classic-decorator": "^1.0.5", "ember-cli-babel": "^7.11.1", "ember-cli-htmlbars": "^4.0.0", "ember-cli-sass": "^10.0.0", diff --git a/packages/toast-message/addon/components/nucleus-toast-message.js b/packages/toast-message/addon/components/nucleus-toast-message.js index 07df612c..8c74a651 100644 --- a/packages/toast-message/addon/components/nucleus-toast-message.js +++ b/packages/toast-message/addon/components/nucleus-toast-message.js @@ -1,4 +1,3 @@ -import classic from 'ember-classic-decorator'; import defaultProp from '@freshworks/core/utils/default-decorator'; import { layout as templateLayout } from '@ember-decorators/component'; import { inject } from '@ember/service'; @@ -15,7 +14,6 @@ import { ICON_MAP } from '../constants/nucleus-toast-message'; @extends Ember.Component @public */ -@classic @templateLayout(layout) class NucleusToastMessage extends Component { /** diff --git a/packages/toast-message/package.json b/packages/toast-message/package.json index 48992cf3..755e4f6c 100644 --- a/packages/toast-message/package.json +++ b/packages/toast-message/package.json @@ -25,7 +25,6 @@ "@freshworks/button": "^0.3.0", "@freshworks/core": "^0.1.5", "@freshworks/icon": "^0.3.0", - "ember-classic-decorator": "^1.0.5", "ember-cli-babel": "^7.11.1", "ember-cli-flash": "^1.7.2", "ember-cli-htmlbars": "^4.0.0", diff --git a/yarn.lock b/yarn.lock index d4e72f7e..ebec34f0 100644 --- a/yarn.lock +++ b/yarn.lock @@ -6266,14 +6266,6 @@ ember-auto-import@^1.5.2: walk-sync "^0.3.3" webpack "~4.28" -ember-classic-decorator@^1.0.5: - version "1.0.5" - resolved "https://registry.yarnpkg.com/ember-classic-decorator/-/ember-classic-decorator-1.0.5.tgz#33f3851ed33c810b56dfb77e25a00160815eaa5a" - integrity sha512-jAZLP1zh7+oTlbvzSI4YTkSb8JS7of9sKQTLpObmah1MP+BCBu39HXKogCdibjWUJzBP2Xp03FQwjquQPuJ2Gw== - dependencies: - babel-plugin-filter-imports "^3.0.0" - ember-cli-babel "^7.11.1" - ember-cli-addon-docs-yuidoc@^0.2.1: version "0.2.3" resolved "https://registry.yarnpkg.com/ember-cli-addon-docs-yuidoc/-/ember-cli-addon-docs-yuidoc-0.2.3.tgz#13f7943c7ef1909d74ef9d33a719236117c17262"