Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(button): improvised styling #137

Merged
merged 12 commits into from
Mar 3, 2020
Merged

fix(button): improvised styling #137

merged 12 commits into from
Mar 3, 2020

Conversation

sharath-sriram
Copy link
Contributor

@sharath-sriram sharath-sriram commented Feb 26, 2020

Resolves #136

This PR includes significant styling improvements to button to ensure a standardised look across all button variants and sizes.

Note: iconOnly=true has been enforced upon all iconOnly buttons

Changes

  1. Centralised iconOnly buttons

Before:
Screenshot 2020-02-26 at 10 59 06 AM

After:
Screenshot 2020-02-26 at 11 00 00 AM

  1. Centralised text inside the buttons

Before:
Screenshot 2020-02-26 at 11 00 19 AM

After:
Screenshot 2020-02-26 at 11 00 28 AM

  1. Aligned icons with text even when iconSize="small"

Before:
Screenshot 2020-02-26 at 11 01 10 AM

After:
Screenshot 2020-02-26 at 2 05 10 PM

  1. Aligned buttons on the same line regardless of their icon sizes.

Before:
Screenshot 2020-02-26 at 11 08 38 AM

After:
Screenshot 2020-02-26 at 11 09 05 AM

@sharath-sriram sharath-sriram marked this pull request as ready for review February 26, 2020 08:44
@shibulijack-fd shibulijack-fd merged commit 6a56cb1 into master Mar 3, 2020
@shibulijack-fd shibulijack-fd deleted the button-feat branch March 3, 2020 10:06
shibulijack-fd added a commit that referenced this pull request Mar 9, 2020
* origin/master:
  feat(docs): Interactive playground component (#140)
  fix(button): block btn issue (#147)
  Revert "chore: updated package versioning (#135)" (#144)
  fix(modal): added submit disabled to confirm-dialog (#146)
  fix(button): improvised styling (#137)
  chore: updated package versioning (#135)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nucleus Button - Alignment Issues
3 participants