fix(banner): system alerts missing bottom padding on scroll (#121) #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #121
This seems to be due to Firefox not applying padding bottom on overflow:scroll/auto items.
Reference link: https://bugzilla.mozilla.org/show_bug.cgi?id=748518
Seems like they dont have plans to fix this as they have closed this as invalid.
Hence, removing padding from Parent container that has overflow:scroll. Adjusting this by adding margin to the child element.
Before Fix:
After Fix:
Tested in chrome, firefox and safari
Related Bug