feat(banner): additional props for banner localisation #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhilashlr89
reviewed
Feb 5, 2020
| * @public | ||
| */ | ||
| @defaultProp | ||
| systemAlerts = 'System Alerts'; |
There was a problem hiding this comment.
Ideally banners should follow conventions as danger, warnings, information, and success. Any reason why we call this API as systemAlerts?
There was a problem hiding this comment.
When there are multiple banners, they are stacked under a "+ [x] more" button. On clicking the button, we get a list of the banners under the title "System Alerts". This is just a prop to customise that title. :)
There was a problem hiding this comment.
The title "System Alerts" itself seems to be a part of the design spec.
There was a problem hiding this comment.
Renamed the props now for clarity.
…to banner-localisation Renamed labels for clarity
shibulijack-fd
approved these changes
Feb 6, 2020
shibulijack-fd
pushed a commit
that referenced
this pull request
Feb 6, 2020
* master: feat(banner): additional props for banner localisation (#103) chore: Lint workflow checks and cleanup (#102) fix: Changed Responsive design (#98) feat: Integrated Visual Regression with ember-backstop (#94) fix: Refactored Github action CI workflow (#96) Removed since (#95) fix(modal): modal patch for safari (#91) fix(nucleus): removed classic decorator dependency (#87) fix(icon): fixed failing tests (#89) [RELEASE] 0.3.0 (#79) # Conflicts: # packages/banner/package.json # packages/button/package.json # packages/inline-banner/package.json # packages/modal/package.json # packages/toast-message/package.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nucleus Banner has two hard-coded instances of text which need to be localised. This PR adds additional props(optional with defaults available) which can be used by the developer to incorporate internationalisation to their banner.