Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Banner component - 'Alerts' missing bottom padding on scroll in Firefox browser #121

Closed
vigneshmanogar opened this issue Feb 19, 2020 · 0 comments · Fixed by #131
Closed

Banner component - 'Alerts' missing bottom padding on scroll in Firefox browser #121

vigneshmanogar opened this issue Feb 19, 2020 · 0 comments · Fixed by #131
Labels
bug Something isn't working

Comments

@vigneshmanogar
Copy link

Description

In Banner component's 'System Alerts' box, the bottom padding is missing when scroll is present. This is observed only in Firefox browser.

Versions

Ember-CLI: 3.11.0
Nucleus: 0.1.0

Current behaviour

There is no padding at the bottom of 'System Alerts' box after scrolling.

image

Expected behaviour

There has to be padding of 8px at the bottom of 'System Alerts' box after scrolling.

image

Steps to reproduce

  1. Open Firefox browser
  2. Go to nucleus documentation site.
  3. Navigate to the 'Banner' component link under 'Components'.
  4. Press success button more than 5 times.
  5. Click on 'more button'.
  6. Scroll to the bottom of the component.

Possible solution
@prakash-chokalingam prakash-chokalingam added the bug Something isn't working label Feb 21, 2020
Vignesh-Manogar-E3433 pushed a commit that referenced this issue Feb 21, 2020
[BUGFIX #121] Fix for Firefox banner component alerts missing bottom …
29640c2 
…padding on scroll
Closed
Vignesh-Manogar-E3433 added a commit that referenced this issue Feb 21, 2020
@Vignesh-Manogar-E3433
Merge branch 'master' into bugfix/#121
7577c9d
Vignesh-Manogar-E3433 pushed a commit that referenced this issue Feb 21, 2020
fix(banner): system alerts missing bottom padding on scroll (#121)
afb7463
Merged
@weekly-digest weekly-digest bot mentioned this issue Feb 23, 2020
Closed
shibulijack-fd added a commit that referenced this issue Feb 24, 2020
@shibulijack-fd
Merge branch 'master' into bugfix/#121-banner
e8081e9
Vignesh-Manogar-E3433 added a commit that referenced this issue Feb 24, 2020
@Vignesh-Manogar-E3433
Merge branch 'master' into bugfix/#121-banner
bff5b5b
Vignesh-Manogar-E3433 added a commit that referenced this issue Feb 24, 2020
@Vignesh-Manogar-E3433
Merge pull request #131 from freshdesk/bugfix/#121-banner
f0a49a3 
fix(banner): system alerts missing bottom padding on scroll (#121)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@prakash-chokalingam @vigneshmanogar