Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup a robust focus trap for modals #120

Closed
kanalveli-ramachandran opened this issue Feb 19, 2020 · 0 comments · Fixed by #148
Closed

Setup a robust focus trap for modals #120

kanalveli-ramachandran opened this issue Feb 19, 2020 · 0 comments · Fixed by #148

Comments

@kanalveli-ramachandran
Copy link
Contributor

Current behaviour

focus is not perferctly trapped inside the modal

Expected behaviour

A focus trap when the modal dialog is opened

Possible solution

https://developers.google.com/web/fundamentals/accessibility/focus/using-tabindex#modals_and_keyboard_traps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(modal): Fixes bugs for focus-trap and autofocus freshworks/nucleus
2 participants
@kanalveli-ramachandran @sharath-sriram