Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new field for AddComponentBounds request and response #269

Open
llucax opened this issue Nov 7, 2024 · 0 comments · May be fixed by #270
Open

Use new field for AddComponentBounds request and response #269

llucax opened this issue Nov 7, 2024 · 0 comments · May be fixed by #270
Labels
part:protobuf Affects the protocol buffer definition files scope:breaking-change Breaking change, users will need to update their code type:enhancement New feature or enhancement visitble to users
Milestone

Comments

@llucax
Copy link
Contributor

llucax commented Nov 7, 2024

What's needed?

SetComponentPower* were updated to use a field called request_lifetime, which an int in seconds with a valid range of [10 seconds, 15 minutes], and when doing so we considered the option to use an enum like in AddComponentBounds, but it was decided to go with this more flexible approach. Also the response for SetComponentPower* uses a field called valid_until for the returned timestamp, which is more explicit and clear than the current ts field for AddComponentBounds.

Proposed solution

Update AddComponentBounds fields to match the fields in SetComponentPower*.

@llucax llucax added part:protobuf Affects the protocol buffer definition files type:enhancement New feature or enhancement visitble to users labels Nov 7, 2024
@llucax llucax added this to the v0.18.0 milestone Nov 7, 2024
@llucax llucax linked a pull request Nov 7, 2024 that will close this issue
@llucax llucax added the scope:breaking-change Breaking change, users will need to update their code label Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
part:protobuf Affects the protocol buffer definition files scope:breaking-change Breaking change, users will need to update their code type:enhancement New feature or enhancement visitble to users
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant