Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: PassKey - Nonce check validation #2030

Closed
aramikm opened this issue Jun 13, 2024 · 0 comments · Fixed by #2039
Closed

[Feature]: PassKey - Nonce check validation #2030

aramikm opened this issue Jun 13, 2024 · 0 comments · Fixed by #2039
Assignees
@aramikm
Milestone
Passkey Signature...

Comments

@aramikm
Copy link
Collaborator

aramikm commented Jun 13, 2024 •
edited
Loading

Feature Description

We avoid replay attacks we will need to implement nonce checks and incrementing nonce for owner account

Acceptence Criterea

  • Implement Nonce check against owner account
  • Add tests
  • Add benchmarks

Notes

  • It is preferable if we can already reuse these implementations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aramikm aramikm

Labels
None yet
Projects
None yet
Milestone
Passkey Signature Transaction Support
Development

Successfully merging a pull request may close this issue.

passkey: nonce check frequency-chain/frequency
2 participants
@aramikm @saraswatpuneet